Fix: ActiveSources + type Sources #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changed - Fixed type activeSource to be initially null and can be set to Source[] or [] by user - added prop .href .description to Source
dani2112
reviewed
Mar 5, 2025
lexio/lib/hooks/hooks.ts
Outdated
There was a problem hiding this comment.
allow setting null from hook?
dani2112
reviewed
Mar 5, 2025
lexio/lib/state/rag-state.ts
Outdated
| // Otherwise use the filtered sources from activeSourcesAtom | ||
| const activeSources = activeSourcesIds.length === 0 | ||
| ? retrievedSources | ||
| const activeSources = activeSourcesIds === null |
There was a problem hiding this comment.
does the atom not return null either way? handling at two places?
|
test failing, check why and fix |
dani2112
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed