Excel viewer displaying data #76
Conversation
There was a problem hiding this comment.
General Feedback on dependecies
we want to limit our dependencies on external libraries, especially for very specific use. Therefore it would be great if you remove the "moment" library and write a js func instead.
Also remove the "swr" library and make use of "useMemo". Same for tailwind-merge, remove dependency on it.
If possible -> replace react-tabs for simple buttons since we do not use the concepts of tabs anywhere else.
Regarding the icons library "lucid-react", we can agree on switching from heroicons -> for this change, please identify where heroicons are used and also replace them to assert consistency. Then remove the "heroicons/react" lib
One personal request
The "New Conversation" button was introduced in the latest new-api merge on main. The button looks a bit weirdly placed in the ChatWindow component. It would be nice if you style it prettier when changing the Icons.
|
I will revisit the code later on |
No description provided.