Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Viewer Toolbar refactoring, fixed flickering Bug in PDFViewer, Handle page prop in PDFSourceContent #65

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Refactor: Viewer Toolbar refactoring, fixed flickering Bug in PDFViewer, Handle page prop in PDFSourceContent #65

merged 6 commits into from
Feb 4, 2025

Conversation

SYoy
Copy link
Collaborator

@SYoy SYoy commented Feb 3, 2025 •
edited
Loading

Changes

  • Fixed flickering page bug when changing pages in PDFViewer
  • Refactored PDFViewerToolbar component
  • Fixed styling bug in Toolbar (wrong background)
  • Changed SourceReference + PDFSourceContent types. Added page prop and add page based on metadata info in reference

Todo

  • Fix types for python / pytests
  • Add description of how "page" works to docs

@SYoy SYoy changed the title Refactor: Viewer Toolbar refactoring Refactor: Viewer Toolbar refactoring, fixed flickering Bug in PDFViewer, Handle page prop in PDFSourceContent Feb 3, 2025
@SYoy SYoy requested a review from dani2112 February 4, 2025 08:47
@dani2112 dani2112 merged commit 83adb39 into main Feb 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani2112 dani2112 dani2112 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYoy @dani2112