Skip to content

refactor(server/main): proper return for SQL insertion #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FjamZoo merged 1 commit into from
May 4, 2025
Merged

refactor(server/main): proper return for SQL insertion #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ local function CreateJobAccount(job, initialBalance)
creator = nil
}

local success, errorMsg = MySQL.insert("INSERT INTO bank_accounts_new (id, amount, transactions, auth, isFrozen, creator) VALUES (?, ?, ?, ?, ?, NULL)", {
local insertId = MySQL.insert.await("INSERT INTO bank_accounts_new (id, amount, transactions, auth, isFrozen, creator) VALUES (?, ?, ?, ?, ?, NULL)", {
job.name,
cachedAccounts[job.name].amount,
json.encode(cachedAccounts[job.name].transactions), -- Convert transactions to JSON
Expand All @@ -616,9 +616,9 @@ local function CreateJobAccount(job, initialBalance)
})

-- Handle potential database errors
if not success then
if not insertId then
cachedAccounts[job.name] = nil
error(("^5[%s]^7-^1[ERROR]^7 %s"):format(currentResourceName, "Database error: " .. tostring(errorMsg)))
error(("^5[%s]^7-^1[ERROR]^7 %s"):format(currentResourceName, "Database error"))
end

return cachedAccounts[job.name]
Expand Down