Implement Forwarding #347
Open
Implement Forwarding #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VelvetToroyashi
approved these changes
Jan 2, 2025
Nihlus
reviewed
Jan 2, 2025
| @@ -67,6 +67,7 @@ | |||
| "message_reference": {}, | |||
| "flags": 1, | |||
| "referenced_message": null, | |||
| "message_snapshots": null, | |||
There was a problem hiding this comment.
This field is optional, not nullable.
Nihlus
requested changes
Jan 2, 2025
| @@ -71,6 +71,7 @@ | |||
| "message_reference": {}, | |||
| "flags": 1, | |||
| "referenced_message": null, | |||
| "message_snapshots": null, | |||
There was a problem hiding this comment.
This field is optional, not nullable.
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "type": 0, | |||
There was a problem hiding this comment.
This field is optional and is missing test data.
| @@ -0,0 +1,45 @@ | |||
| { | |||
| "message": { | |||
There was a problem hiding this comment.
MessageSnapshot contains no optional fields - this file is redundant and can be deleted.
| @@ -0,0 +1,45 @@ | |||
| { | |||
| "message": { | |||
There was a problem hiding this comment.
Please add a separate file where the partial message is an empty object (MESSAGE_SNAPSHOT.partials.json) - we want to cover both a populated and unpopulated message path.
Nihlus
added
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds data structures to support forwarding