Test/remit split schedule id sequencing#412
Open
Agbasimere wants to merge 7 commits intoRemitwise-Org:mainfrom
Open
Test/remit split schedule id sequencing#412Agbasimere wants to merge 7 commits intoRemitwise-Org:mainfrom
Agbasimere wants to merge 7 commits intoRemitwise-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #250
Description
This PR implements replay-safe schedule ID sequencing for the RemittanceSplit contract. It ensures that every remittance schedule is assigned a strictly monotonic, unique identifier, preventing ID collisions even across high-volume creation and modification cycles.
Key Changes
NEXT_RSCHstorage counter to generate unique IDs.checked_addto prevent u32 overflow vulnerabilities, returningRemittanceSplitError::Overflowif the limit is reached.contains_key) before assignment as a "defense-in-depth" measure for ID uniqueness.Verification & Testing
Unit & Stress Tests
Added a suite of validation tests in remittance_split/tests/stress_test_large_amounts.rs:
Security Invariants