feat: harden reporting init and admin authorization paths#400
Merged
Baskarayelu merged 3 commits intoRemitwise-Org:mainfrom Mar 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR strengthens the security of the
reporting
contract by implementing a two-step admin rotation process and hardening the initialization path to prevent unauthorized takeovers and re-initialization attacks.
Closes #308
Changes
Hardened
init
: Updated the initialization logic to ensure it can only be called once and requires the initial administrator's authorization.
Two-Step Admin Rotation: Added a secure
propose_new_admin
and
accept_admin_rotation
flow, mitigating the risk of accidental or malicious admin loss.
Result-Based Error Handling: Refactored administrative functions (
configure_addresses
,
archive_old_reports
,
cleanup_old_reports
) to return Result types with specific error codes instead of panicking.
NatSpec Documentation: Implemented comprehensive documentation for all public functions, detailing security assumptions and error states.
Workspace Stability: Fixed pre-existing compilation errors in remitwise-common and duplication in the reporting tests.
Verification Results
Added 5 new test cases covering the entire admin rotation lifecycle and unauthorized access attempts.
All 53 tests in the
reporting
package are passing successfully.
Verified manual security assumptions for cross-contract authorization.