Test/family wallet multisig emergency gas#380
Open
RemmyAcee wants to merge 25 commits intoRemitwise-Org:mainfrom
Open
Test/family wallet multisig emergency gas#380RemmyAcee wants to merge 25 commits intoRemitwise-Org:mainfrom
RemmyAcee wants to merge 25 commits intoRemitwise-Org:mainfrom
Conversation
Contributor
|
Please resolve the conflicts |
Author
|
Done, Close: #380 |
Contributor
|
@RemmyAcee Please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #297
I have successfully implemented the gas benchmark suite for the family_wallet contract and enhanced its documentation with NatSpec-style comments.
Key achievements:
Gas Benchmark Suite: Created family_wallet/tests/gas_bench.rs covering multisig proposals, signing (including execution triggers), direct emergency transfers, and bulk archival/cleanup operations.
Performance Metrics: Captured baseline gas and memory usage for all key operations on Soroban Protocol 22.
Enhanced Documentation: Added NatSpec-style comments to critical contract functions in family_wallet/src/lib.rs for improved auditability.
100% Test Pass Rate: Verified the entire workspace with 69 passing tests (61 existing + 8 new benchmarks).
GAS_README.md: Created a detailed guide and results table in benchmarks/GAS_README.md.