Feature/insurance batch premium semantics#348
Open
AbuJulaybeeb wants to merge 26 commits intoRemitwise-Org:mainfrom
Open
Feature/insurance batch premium semantics#348AbuJulaybeeb wants to merge 26 commits intoRemitwise-Org:mainfrom
AbuJulaybeeb wants to merge 26 commits intoRemitwise-Org:mainfrom
Conversation
added 16 commits
March 23, 2026 19:59
Contributor
|
Please resolve the conflicts |
…imports in scenarios
…ily Wallet, Orchestrator and Insurance contracts
…tance_split tests
Author
|
Please review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #280
Refactored the batch_pay_premiums logic in insurance/src/lib.rs to ensure deterministic batch processing. This update prevents the entire batch from reverting when encountering invalid states (e.g., inactive or unauthorized policies), allowing for partial success execution.
Key Changes
Implemented safer batch handling to avoid full transaction failure on individual policy errors.
Introduced InsuranceEvent::BatchPaymentResult to provide clear feedback on:
Total number of policies processed
Number of successful payments
Reworked and expanded test coverage in insurance/src/test.rs to validate mixed batch scenarios, including:
Valid policies
Inactive policies
Unauthorized policies
Resolved over 40 critical syntax and compilation issues across insurance/src/lib.rs and insurance/src/test.rs, including:
Missing module closures
Stray or improperly injected code
Duplicate or conflicting function signatures
Impact
Improves system resilience by enabling partial batch execution
Enhances observability through structured event reporting
Restores CI stability and ensures successful builds