fix(frontend): normalize API and wallet errors safely - #290
Open
isaacsamual994-lang wants to merge 9 commits into
Open
fix(frontend): normalize API and wallet errors safely#290isaacsamual994-lang wants to merge 9 commits into
isaacsamual994-lang wants to merge 9 commits into
Conversation
Author
|
@arisu6804 #283 is implemented and ready for review in this PR. The branch is conflict-free and the local test/build validation is included above. GitHub is currently showing two workflows awaiting maintainer approval; when you have a chance, could you please approve those runs and review the change? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalizes API and wallet failures into a small safe error shape so raw provider responses, server details, wallet addresses, and token-like values are not surfaced to users. The normalized policy also carries explicit retryability and a validated correlation/request identifier for protected diagnostics.
Motivation
Issue #283 calls out two related problems: provider/server details can leak sensitive account data into user-facing errors, and callers can make unsafe retry decisions when failures are not classified consistently.
Changes Made
Testing
24Vitest files /135tests passed locally using the repository's integration/unit/Lighthouse-config test paths with thread workers (the default fork pool is blocked by the Charlotte sandbox's process permissions).npm run buildpassed.git diff --checkpassed.Screenshots (if applicable)
Not applicable; this changes error handling/messages and retry policy without layout or styling changes.
Checklist
Closes #283