Add a (FIXED N) type for fixed-length byte arrays - #277
Merged
Merged
Conversation
`FixedType { int32 length }` in the `Type` oneof, written `(FIXED N)`. In CSV data a
value is 2N hex digits, most significant byte first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
comnik
reviewed
Sep 26, 2026
comnik
approved these changes
Sep 26, 2026
Co-authored-by: Nikolas Göbel <nikolas.goebel@relational.ai>
This was referenced Sep 28, 2026
hbarthels
added a commit
that referenced
this pull request
Sep 28, 2026
Makes the `(FIXED N)` type from #277 available downstream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hbarthels
added a commit
that referenced
this pull request
Sep 28, 2026
The review suggestion applied in #277 shortened the `FixedType` comment in `logic.proto` without regenerating, so `logic.pb.go` still carried the old doc comment. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
hbarthels
added a commit
that referenced
this pull request
Sep 28, 2026
Makes the `(FIXED N)` type from #277 available downstream. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
(FIXED N), an N-byte array type. It gives LQP a way to declare binary identifiers such as MD5 digests or UUIDs, which are stored as hex in CSV and asfixed[N]in Iceberg:In CSV data a value is written as 2N hex digits, most significant byte first. That matches Snowflake's
MD5output and its big-endianMD5_NUMBER_UPPER64. The protocol accepts any N. The engine will initially support only(FIXED 16), stored as a UINT128, and reject other lengths when lowering.FixedType { int32 length }asfixed_type = 15in theTypeoneof. It is additive:buf breakingagainstmainis clean."(" "FIXED" INT ")", following(DECIMAL p s).==/isequal/hashforFixedType, andFixedTypeadded toLQPSyntax.FIXED. LikeDECIMAL, the name leaves out the parameter.Most of the diff is regenerated parser, printer and protobuf code for the three SDKs. The hand-written changes are in
logic.proto,grammar.y, the Julia equality files,proto_validator.py, and the fixture.🤖 Generated with Claude Code