Slight simplification to install and build commands#25
Open
jcadcell wants to merge 1 commit intoReggino:masterfrom
Open
Slight simplification to install and build commands#25jcadcell wants to merge 1 commit intoReggino:masterfrom
jcadcell wants to merge 1 commit intoReggino:masterfrom
Conversation
Owner
|
Thanks, looks great. I'm away from keyboard for a few days, but i'll review in more detail and release a new version later this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the install and build scripts. The postinstall step was not working on my system. Moving it up a level solved that. I also included the git submodule steps as a postinstall step. I did not have grunt installed globally, but by adding the script I can run it through npm. Finally, I added a shortcut to start chrome with the --disable-web-security flag. The documentation is also updated.