Converge >= and > usage in docs and implementation of GESVJ #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langou
approved these changes
Sep 17, 2024
|
At first glance, this looks good to me. If the CI goes green after a rebase, this is probably ready for merge, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation and the code of GESVJ deviate in two spots with respect to the usage of
.GT.and.GE.:lapack/SRC/dgesvj.f
Line 106 in 4b3d8a4
lapack/SRC/dgesvj.f
Line 501 in 4b3d8a4
The PR takes the version in the code and updates the documentation.
lapack/SRC/dgesvj.f
Line 217 in 4b3d8a4
lapack/SRC/dgesvj.f
Line 445 in 4b3d8a4
This deviation is fixed in the code, which now literally permits EPS as threshold.