Wallpaper setting download issues#19
Open
hugoalvarado wants to merge 2 commits into
Open
Conversation
Removed Newtonsoft.Json dependency
-Small fixes to wallpaper save logic -Adds basic validation of the wallpaper url -Adds GetWallpaperPath function, returns the default wallpaper save path
|
Woops, should have looked here first, before submitting mine #26 The deal with the toast is that it cannot be called from non-UI thread so it has to be wrapped into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Redth,
I noticed the custom wallpaper setting was not working, so I made a few fixes. The main issue was a problem with the default filename path, since it was always null, and broke the http.DownloadData() call.
The Toast.MakeText was not working, but it did work in other screens, not sure why. I commented that out in the try/catch.
The apli level for the firetv stick is 17(android 4.2) but your project has 4.3 and 4.4. I set it back to 4.2. https://developer.amazon.com/public/solutions/devices/fire-tv/docs/device-and-platform-specifications
I was able to build and debug without problems using the basic xamarin licence, all thanks for your previous commit "Removed Newtonsoft.Json dependency".
Thank for this cool launcher!
-Hugo