-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #16
Open
NULLProtogen
wants to merge
9
commits into
Redherring32:master
Choose a base branch
from
NULLProtogen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cleanup #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up some traces and errors in the PCB editor. Most of the changes won't actually be visible on a manufactured board but cleans things up for anyone who wants to poke around in the editor. Nudged some solder masks and traces around to remove overlaps. and cleaned up copper zones making many of the runs smoother and look better but should not any real impact on the finished product. I noticed that the physical board that I received has a "P6-Alt" connector that was not present in the editor so I added that.
Cleaned up some traces and errors in the PCB editor. Most of the changes won't actually be visible on a manufactured board but cleans things up for anyone who wants to poke around in the editor. Nudged some solder masks and traces around to remove overlaps. and cleaned up copper zones making many of the runs smoother and look better but should not any real impact on the finished product. I noticed that the physical board that I received has a "P6-Alt" connector that was not present in the editor so I added that. Added Redherring32's NullCIC design built into the main board instead of as a daughter board. You can choose to either populate the CIC or the capacitor, resistor, and IC under it. Updated schematic to reflect changes to the PCB
P6 Alt was removed from master to bring it more inline with the OEM board. It was instead moved to the "feature" branch. For everything else I'll have to review it tonight. :) |
Cleaned up some traces and errors in the PCB editor. Most of the changes won't actually be visible on a manufactured board but cleans things up for anyone who wants to poke around in the editor. Nudged some solder masks and traces around to remove overlaps. and cleaned up copper zones making many of the runs smoother and look better but should not any real impact on the finished product. I noticed that the physical board that I received has a "P6-Alt" connector that was not present in the editor so I added that. Added Redherring32's NullCIC design built into the main board instead of as a daughter board. You can choose to either populate the CIC or the capacitor, resistor, and IC under it. Updated schematic to reflect changes to the PCB
Added Pwr Btn/Rst Btn Board
Added power/RF Board. Could not find info to build in RF so I used mspinksosu's design for an RF board that has composit video and dual mono audio out instead.
Did some clean up. Each board has its own folder and schematic. Certain changes were chanting nets that were unrelated and causing issues. Separating them will prevent this. I believe best practice is to have it this way any how. Side notes: The A/V connectors have the wrong footprint. These are place holders till I decide what connectors I want to use. I left the previous schematics and PCB in the root folder so I can refer to them later but they will likely not be updated from this point forward and may be removed later on.
Added board option with built in AV/Power and corrected the old oversized RCA place holders with accurate footprints. Nothing is tested at this point but some quick eye math tells me that both boards can be combined.
It seems you've added commits to this PR's branch meant for your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some traces and errors in the PCB editor. Most of the changes won't actually be visible on a manufactured board but cleans things up for anyone who wants to poke around in the editor.
Nudged some solder masks and traces around to remove overlaps. and cleaned up copper zones making many of the runs smoother and look better but should not any real impact on the finished product.
I noticed that the physical board that I received has a "P6-Alt" connector that was not present in the editor so I added that.