-
Notifications
You must be signed in to change notification settings - Fork 29
Support for running Components within Docker Containers #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available at the GPP
…o docker-gpp Conflicts: GPP/cpp/GPP.cpp
… available at the GPP
… into wip-docker-gpp Conflicts: GPP/cpp/GPP.cpp
Base class ID for docker_volume was wrong. Closes RedhawkSDR#3 See merge request !1
…rked external so that Components can use them as property references.
Bug fix for properties not being marked as external Closes RedhawkSDR#4 See merge request !2
Closing this PR as OBE by PR #6 which is still being evaluated for inclusion in a future version of the GPP. Thank you for your contribution to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an extension to the standard GPP that, if present and permitted, allows the GPP to use Docker to execute a Component from within its own Docker Container rather than the GPP's environment. This is useful for when a Component has environmental dependencies that are not easily portable in the usual manner (softpkg dependencies, for example).
This extension does not make the GPP require Docker since it is only accessing it from the command line.
The requirement on the Component's Docker Container is that it contains the same release of REDHAWK SDR and its WORKDIR is set to
$SDRROOT/dom
.This extension includes 3 new properties named
docker_omniorb_cfg
,docker_image
, anddocker_volume
/etc/omniORB.cfg
through volume mappingThis extension requires a dependent Component to set the exec (command line) property IDs
__DOCKER_IMAGE__
and, optionally,__DOCKER_ARGS__
. The first should be equal to thedocker_image
dependency, above. And the latter should contain volume mounting information if anydocker_volume
names are included. Otherwise it can be populated with any additional Docker runtime arguments the Component requires.An early demo of this (predating the allocation properties) can be seen here.