Added GET endpoints for activities#43
Closed
guntejsingh27 wants to merge 2 commits intoRedback-Operations:mainfrom
Closed
Added GET endpoints for activities#43guntejsingh27 wants to merge 2 commits intoRedback-Operations:mainfrom
guntejsingh27 wants to merge 2 commits intoRedback-Operations:mainfrom
Conversation
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
jd-deakin
suggested changes
Sep 10, 2025
jd-deakin
left a comment
There was a problem hiding this comment.
Please check report.json.
If this information should be public, please message me on teams to explain in more depth what the data is.
At first glance, this appears to be a breach of API keys, and their secrets.
If so, this will need immediate action, including rotating the keys.
Additionally, you should not be shipping a .db file to the repo.
Author
|
Hello,
While doing the pull request, 3 additional files were added which were not required.
I'm going to make another pull request without these files getting added.
This should be fine?
Please let me know.
Kind Regards,
Guntej
Sent on the go with Vodafone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: jd-deakin ***@***.***>
Sent: Wednesday, September 10, 2025 5:59:36 PM
To: Redback-Operations/redback-fit-backend ***@***.***>
Cc: GUNTEJ SINGH ***@***.***>; Author ***@***.***>
Subject: Re: [Redback-Operations/redback-fit-backend] Added GET endpoints for activities (PR #43)
@jd-deakin requested changes on this pull request.
Please check report.json.
If this information should be public, please message me on teams to explain in more depth what the data is.
At first glance, this appears to be a breach of API keys, and their secrets.
If so, this will need immediate action, including rotating the keys.
Additionally, you should not be shipping a .db file to the repo.
—
Reply to this email directly, view it on GitHub<#43 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHPCPZHIECHY4QT2R7L6GAD3R7K6RAVCNFSM6AAAAACF5NULVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMBUHEZTSMBXGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
|
Just to carry on from the email activity.py was the only file I wanted to add for the PR. The other 3 additional files should not have been added. |
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
Member
|
changes added in new PR, closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented two GET routes: fetch all activities and fetch activity by ID.