fix: call backand service getting api url from settings and fix parameter encoding #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnicolli
reviewed
Dec 1, 2021
src/Block/RssBody.jsx
Outdated
| @@ -10,8 +10,8 @@ const RssBody = ({ data, isEditMode }) => { | |||
| let parser = new Parser(); | |||
| setFeedItems([]); | |||
| if (data?.feed?.length > 0) { | |||
| let base_url = config.settings.apiPath; | |||
| parser.parseURL(base_url + '/@get_rss_feed?feed=' + data.feed, function ( | |||
| let base_url = config.settings.devProxyToApiPath; | |||
There was a problem hiding this comment.
Now that I read this with more attention to details, I think devProxyToApiPath could be wrong here. It should only be used in development, it will not be there in production.
|
LGTM to encode the URL but the url to api shouldn't be that |
luca-bellenghi
force-pushed
the
us_22826_fix_rss
branch
2 times, most recently
from
c6c8335 to
2300b00
Compare
luca-bellenghi
force-pushed
the
us_22826_fix_rss
branch
from
2300b00 to
05d2d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.