-
Notifications
You must be signed in to change notification settings - Fork 51
[4.19]Rename kubevirt_vmi_migration_disk_transfer_rate_bytes metric #2712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cnv-4.19
Are you sure you want to change the base?
[4.19]Rename kubevirt_vmi_migration_disk_transfer_rate_bytes metric #2712
Conversation
The metric kubevirt_vmi_migration_disk_transfer_rate_bytes renamed, this PR refactoring the old metric name to the new one.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
dshchedr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you didn't update place where it is used
|
@OhadRevah please don't create manual cherry-picks while main PR is not merged. |
b3bcebc to
dc31823
Compare
|
/retest all |
|
/verified |
|
/hold @OhadRevah when code needs to be backported, do not open backport PRs while the original PR was not merged |
Short description:
The metric kubevirt_vmi_migration_disk_transfer_rate_bytes renamed, this PR refactoring the old metric name to the new one.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://issues.redhat.com/browse/CNV-62623