Skip to content

Fix the valid_cdi_certificate fn to fetch utc time instead of localtime. #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

Fix the valid_cdi_certificate fn to fetch utc time instead of localtime. #2148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tests/storage/test_cdi_certificate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import datetime
import logging
import subprocess
import time

import pytest
from ocp_resources.cdi import CDI
Expand Down Expand Up @@ -83,14 +82,11 @@ def valid_cdi_certificates(secrets):
LOGGER.info(f"Checking {cdi_secret}...")

start = secret.certificate_not_before
start_timestamp = time.mktime(time.strptime(start, RFC3339_FORMAT))

end = secret.certificate_not_after
end_timestamp = time.mktime(time.strptime(end, RFC3339_FORMAT))

current_time = datetime.datetime.now().strftime(RFC3339_FORMAT)
current_timestamp = time.mktime(time.strptime(current_time, RFC3339_FORMAT))
assert start_timestamp <= current_timestamp <= end_timestamp, f"Certificate of {cdi_secret} expired"
start_dt = datetime.datetime.strptime(start, RFC3339_FORMAT).replace(tzinfo=datetime.timezone.utc)
end_dt = datetime.datetime.strptime(end, RFC3339_FORMAT).replace(tzinfo=datetime.timezone.utc)
now_dt = datetime.datetime.now(datetime.timezone.utc)
assert start_dt <= now_dt <= end_dt, f"Certificate of {cdi_secret} not valid at current time"


@pytest.fixture()
Expand Down