[RHCLOUD-36900] add pre-commit github action into repo #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petracihalova
force-pushed
the
pre-commit-gh-action
branch
2 times, most recently
from
3bc6672 to
69a600d
Compare
petracihalova
force-pushed
the
pre-commit-gh-action
branch
from
69a600d to
4d34e52
Compare
Ellen-Yi-Dong
approved these changes
Dec 12, 2024
petracihalova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHCLOUD-36900
moved pre-commit check in own github action
and
update
blackto the latest version in pre-commit configmotivation: in previous version the pre-commit check runs via Jenkins worker with python 3.8 and that was not align with python 3.9 we use in the project, additionally it was not possible to use latest
blackversion (requires python >= 3.9)moving into own github action we can better distinguish between pre-commit checks and rest pr check defined in the
pr_check.sh