Draft
Conversation
* Card ID - CCT-148 This commit also updates the .gitignore file to avoid committing .mo files. Also the VERSION extraction in the Makefile has been modified, since testing in RHEL 10.1 was resulting in weird behavior obtaining the following: [vagrant@lv-rhel101 rhc]$ rpmspec rhc.spec --query --queryformat '%{version}' 0.3.80.3.80.3.8 While the expected was 0.3.8, the modification makes it more robust. Signed-off-by: mjcr99 <macano@redhat.com>
…m into the package * Card ID - CCT-148 Signed-off-by: mjcr99 <macano@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR needs #362 to be merged to properly work.
Hi team, this PR implements the required changes to include translations in rhc builds, following are the key aspects covered:
.mofiles by callingmake i18ntarget.Testing
To fully test this development, the following patch is provided es_test.patch, which includes the Spanish translation
.pofile. Apply it and commit it in a testing commit to let the Makefilearchivetarget include it.After it, follow the packaging instructions to create a package
The generated package is queried to check if it contains the generated translation:
After it, the package can be installed:
Finally, the
rhccli can be called directly, indicating the preferred language, and the output is modified: