Open
Conversation
Contributor
|
Should we test the case where the log file couldn't be opened? An error message will be printed with something like: |
DuckBoss
requested changes
Feb 27, 2026
Collaborator
DuckBoss
left a comment
DuckBoss
left a comment
There was a problem hiding this comment.
Thanks for the PR, I have some suggestions after an initial review.
Contributor
Author
Test added: test_log_file_open_failure_message |
jlocash
previously approved these changes
Mar 5, 2026
Contributor
jlocash
left a comment
jlocash
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM
DuckBoss
requested changes
Mar 5, 2026
Collaborator
DuckBoss
left a comment
DuckBoss
left a comment
There was a problem hiding this comment.
Thanks for the changes! It mostly LGTM, I have some small cleanup changes and one issue I ran into during testing that can be fixed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test coverage for the Logging Framework in RHC - CCT-1820
The test suite is designed for compatibility with Polarion entries. The test cases are mapped to the RHSS-291811 - RHC - Logging mechanism for the CLI requirement.