Draft
Conversation
- removed all dbus calls from cmd/ - removed all urfave/cli usage from internal/rhsm - implemented rhsm.RegisterServer for wrapping the private D-Bus connection and registration methods - moved calling code to cmd/rhc Signed-off-by: Joshua Locash <[email protected]> Assisted-by: Claude Code
jlocash
force-pushed
the
jlocash/refactor-rhsm
branch
from
2843b69 to
3b0ff53
Compare
Contributor
Author
|
Would like to wait for #346 to be merged before this PR as there will be conflicts |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally intended to include these changes with #342, but did not want to include any refactors in that PR.
I felt the separation of concerns between cmd/rhc and internal/rhsm could be improved. I believe
cmd/rhcshould include all code relating to user-interactions (reading input, printing etc) and registration flow, and internal/rhsm should provide the APIs to make it happen.Included in this PR are the following changes:
rhsm.RegisterServerfor wrapping the private D-Bus connectionrhsm.RegisterRHSMfunction to cmd/rhc package