-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-35963] - Added annotations for principals when filtering groups by exclude_use… #1387
base: master
Are you sure you want to change the base?
[RHCLOUD-35963] - Added annotations for principals when filtering groups by exclude_use… #1387
Conversation
…rname or username
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I commented on the PR but can't find it 😅
LGTM, better to have one more to take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvanCasey13
Check some combinations of tests, for the username=<user>
the principalCount
is always showing 1 even when there are more users inside the groups in the result.
… in not restricted
/retest |
it looks like unit tests are failing |
/retest |
QE: Passed (manual) |
…rname or username
Link(s) to Jira
(https://issues.redhat.com/browse/RHCLOUD-35963)
Description of Intent of Change(s)
Added annotations for principal count when filtering group using exclude_username or username query parameters
Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist