-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-37616 - Added ability to filter service accounts by na… #1309
Closed
EvanCasey13
wants to merge
23
commits into
RedHatInsights:master
from
EvanCasey13:sorting_for_service_accounts
Closed
RHCLOUD-37616 - Added ability to filter service accounts by na… #1309
EvanCasey13
wants to merge
23
commits into
RedHatInsights:master
from
EvanCasey13:sorting_for_service_accounts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, owner or description. Added tests cases for service account filtering
…ted, clientId, tests created for time_created ascending & descending sorting for service accounts
…/insights-rbac into sorting_for_service_accounts
…tests for sorting by owner
…nd ordering were provided
…/insights-rbac into sorting_for_service_accounts
…filtering service accounts
…/insights-rbac into sorting_for_service_accounts
@EvanCasey13 Probably do we need to update the OpenAPI specs to add the options, don't we? |
…/insights-rbac into sorting_for_service_accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me, owner or description. Added tests cases for service account filtering
Link(s) to Jira
https://issues.redhat.com/browse/RHCLOUD-29904
Description of Intent of Change(s)
Implemented filtering for service accounts on name, owner and description with test cases for filtering. Implemented sorting of service accounts by Service Account Name, Description, Client ID, Owner & Time created both ascending and descending.
Local Testing
How can the feature be exercised?
Running this curl commands replacing the filtering parameter with the valid fields of name, owner or description.
curl -v "http://localhost:8000/api/rbac/v1/principals/?type=service-account&name=e6921ca0-9cd3-013c-1dc6-6aa2427b506a-name" -H "accept: application/json" | json_pp
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist