Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-37616 - Added ability to filter service accounts by na… #1309

Conversation

EvanCasey13
Copy link
Contributor

@EvanCasey13 EvanCasey13 commented Nov 14, 2024

…me, owner or description. Added tests cases for service account filtering

Link(s) to Jira

https://issues.redhat.com/browse/RHCLOUD-29904

Description of Intent of Change(s)

Implemented filtering for service accounts on name, owner and description with test cases for filtering. Implemented sorting of service accounts by Service Account Name, Description, Client ID, Owner & Time created both ascending and descending.

Local Testing

How can the feature be exercised?
Running this curl commands replacing the filtering parameter with the valid fields of name, owner or description.

curl -v "http://localhost:8000/api/rbac/v1/principals/?type=service-account&name=e6921ca0-9cd3-013c-1dc6-6aa2427b506a-name" -H "accept: application/json" | json_pp

How can the bug be exploited and fix confirmed?
Is any special local setup required?

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@EvanCasey13 EvanCasey13 changed the title [WIP][RHCLOUD-29904] - Added ability to filter service accounts by na… [RHCLOUD-29904] - Added ability to filter service accounts by na… Nov 20, 2024
@vbelchio
Copy link
Contributor

vbelchio commented Jan 9, 2025

@EvanCasey13 Probably do we need to update the OpenAPI specs to add the options, don't we?

@EvanCasey13 EvanCasey13 changed the title [RHCLOUD-29904] - Added ability to filter service accounts by na… - Added ability to filter service accounts by na… Jan 30, 2025
@EvanCasey13 EvanCasey13 changed the title - Added ability to filter service accounts by na… RHCLOUD-37616 - Added ability to filter service accounts by na… Jan 30, 2025
@EvanCasey13 EvanCasey13 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants