Skip to content

fix: Group filter & Filter chip fixes #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix: Group filter & Filter chip fixes #2245

merged 2 commits into from
Oct 13, 2025

Conversation

@bastilian
Copy link
Member

@bastilian bastilian commented Sep 23, 2025 •
edited
Loading

This PR fixes some things in for the PrimaryToolbar/ConditionalFilter.

  • Restores proper groupSelectable behaviour as introduced in Add SelectOption for a group #1112
  • Changes the FilterChips to only show a group deletion if there are more than one item
groupfilterselectionfixes.mp4

@bastilian bastilian changed the title Group filter fixes fix: Group filter & Filter chip fixes Sep 23, 2025
@bastilian bastilian mentioned this pull request Sep 23, 2025
Open
@bastilian bastilian mentioned this pull request Sep 24, 2025
Draft
@bastilian bastilian marked this pull request as ready for review September 24, 2025 20:17
@bastilian bastilian requested a review from a team September 24, 2025 20:17
@bastilian bastilian force-pushed the group_filter_fixes branch 2 times, most recently from db78e69 to e7fee69 Compare September 24, 2025 20:26
raswonders
raswonders approved these changes Sep 25, 2025
View reviewed changes
Copy link

@raswonders raswonders left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for storybook in tabletools, having trouble to verify in Inventory because of RBAC issues once I substitute debs in node_modules.

LightOfHeaven1994
LightOfHeaven1994 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for working on this!

@bastilian bastilian added the release Once merged it will trigger bugfix release label Oct 13, 2025
@bastilian bastilian merged commit 8e89278 into RedHatInsights:master Oct 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LightOfHeaven1994 LightOfHeaven1994 LightOfHeaven1994 approved these changes

@karelhala karelhala Awaiting requested review from karelhala

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

+1 more reviewer

@raswonders raswonders raswonders approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release Once merged it will trigger bugfix release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bastilian @raswonders @LightOfHeaven1994