Skip to content

Conversation

grantsydney
Copy link
Collaborator

No description provided.

@velias
Copy link
Collaborator

velias commented Sep 23, 2025

Update docs/guide/renderer/patternfly_npm.md to include readme from the new repo please, raw content url has to be used in it https://raw.githubusercontent.com/RedHat-UX/next-gen-ui-react/refs/heads/main/README.md

@velias
Copy link
Collaborator

velias commented Sep 23, 2025

@Hrithik-Gavankar can this affect your NPM test app? I'm not sure where do you take NPM package from.

We should also figure out how to take newest version/code of the NPM package into "test app"/"QA env deplpoyment" before it is really released and pushed into NPM repository, so we can test it here even before the release.
FYI @eyevana @bennypowers @nzadapredhat

@Hrithik-Gavankar
Copy link
Collaborator

@velias Yes, this will significantly impact the ngui-e2e test application.

## Current Architecture & Dependencies

The `tests/ngui-e2e/client` project has a critical dependency on `libs_js/next_gen_ui_react` for local development and testing. Currently, we use npm linking to connect the React package with the E2E demo:

- The E2E app imports and uses components from the `dynamicui` package
- Local development relies on `npm link` to connect the built package from `libs_js/next_gen_ui_react`
- This allows real-time testing of React component changes within the full NGUI workflow
- The setup enables validation of AI-generated UI components using actual React components

## What Gets Broken

Removing `libs_js/` would break:

1. Local Development Workflow: Developers can't test React component changes in the E2E context
2. Component Integration Testing: No way to validate NGUI agent output with actual React rendering
3. QA Environment Setup: The deployment plan assumes local package availability for testing
4. Documentation: Current README instructions become invalid
5. CI/CD Pipeline: Any automated testing that depends on the local package link

## Impact on Deployment Strategy

This also affects our deployment planning since the E2E app serves as the testing ground for the React package before production deployment. Without it, we lose the ability to validate the complete NGUI workflow locally.

## Solution

**Publish the React package to npm (including pre-release versions) so ngui-e2e can install it directly instead of relying on local linking.**

cc: @anujrajak 

@eyevana
Copy link
Collaborator

eyevana commented Sep 23, 2025

@velias @Hrithik-Gavankar let's publish under a pre-release version like 1.0.0-alpha.0 and when we're stable, we can release at 1.0.0, wdyt? Publish PR can be found here: RedHat-UX/next-gen-ui-react#1

@velias
Copy link
Collaborator

velias commented Sep 25, 2025

Agree. I expect we will have to publish that pre-release versions in the future as part of the NPM dev/test/release process, to allow testing (using test app) before release. Document this process somewhere please, ideally in CONTRIBUTING.md in the new NPM repo?

@Hrithik-Gavankar
Copy link
Collaborator

Hrithik-Gavankar commented Sep 25, 2025

@eyevana publishing under 1.0.0-alpha.0 before moving to stable 1.0.0 sounds good.
Aligned with @velias on documenting the process in CONTRIBUTING.md

@grantsydney
Copy link
Collaborator Author

@velias I updated the readme
@Hrithik-Gavankar I had moved the e2e files to the new repo here. Should that directory remain in this repo and not in next-gen-ui-react? Or should I leave the new repo as is and delete it from this repo

@grantsydney grantsydney marked this pull request as ready for review September 25, 2025 21:15
@Hrithik-Gavankar
Copy link
Collaborator

As discussed, the e2e folder should remain under tests/ngui-e2e in this repo.
Thanks, @grantsydney for the above.

@velias
Copy link
Collaborator

velias commented Oct 1, 2025

@grantsydney @Hrithik-Gavankar looks good to me, feel free to merge

@grantsydney grantsydney merged commit 0ea6fee into main Oct 1, 2025
6 checks passed
@grantsydney grantsydney deleted the NGUI-358 branch October 1, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants