-
Notifications
You must be signed in to change notification settings - Fork 0
chore(NGUI-358): remove frontend #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update |
@Hrithik-Gavankar can this affect your NPM test app? I'm not sure where do you take NPM package from. We should also figure out how to take newest version/code of the NPM package into "test app"/"QA env deplpoyment" before it is really released and pushed into NPM repository, so we can test it here even before the release. |
@velias Yes, this will significantly impact the ngui-e2e test application.
## Current Architecture & Dependencies
The `tests/ngui-e2e/client` project has a critical dependency on `libs_js/next_gen_ui_react` for local development and testing. Currently, we use npm linking to connect the React package with the E2E demo:
- The E2E app imports and uses components from the `dynamicui` package
- Local development relies on `npm link` to connect the built package from `libs_js/next_gen_ui_react`
- This allows real-time testing of React component changes within the full NGUI workflow
- The setup enables validation of AI-generated UI components using actual React components
## What Gets Broken
Removing `libs_js/` would break:
1. Local Development Workflow: Developers can't test React component changes in the E2E context
2. Component Integration Testing: No way to validate NGUI agent output with actual React rendering
3. QA Environment Setup: The deployment plan assumes local package availability for testing
4. Documentation: Current README instructions become invalid
5. CI/CD Pipeline: Any automated testing that depends on the local package link
## Impact on Deployment Strategy
This also affects our deployment planning since the E2E app serves as the testing ground for the React package before production deployment. Without it, we lose the ability to validate the complete NGUI workflow locally.
## Solution
**Publish the React package to npm (including pre-release versions) so ngui-e2e can install it directly instead of relying on local linking.**
cc: @anujrajak |
@velias @Hrithik-Gavankar let's publish under a pre-release version like |
Agree. I expect we will have to publish that pre-release versions in the future as part of the NPM dev/test/release process, to allow testing (using test app) before release. Document this process somewhere please, ideally in |
@velias I updated the readme |
This reverts commit 4f9608f.
As discussed, the e2e folder should remain under tests/ngui-e2e in this repo. |
@grantsydney @Hrithik-Gavankar looks good to me, feel free to merge |
No description provided.