Skip to content

Conversation

lkrzyzanek
Copy link
Collaborator

@lkrzyzanek lkrzyzanek commented Sep 3, 2025

A2A protocol support.
See README.md

@lkrzyzanek lkrzyzanek changed the title feat: a2a protocol support feat(NGUI-223): a2a protocol support Sep 17, 2025
@lkrzyzanek lkrzyzanek requested a review from unibrew September 17, 2025 07:43
@unibrew
Copy link
Collaborator

unibrew commented Sep 17, 2025

The code looks good. Just a general comment that I would make README.md less code heavy and more text. I don't think it makes a lot of sense having the same code in readme and in separate python files. They will surely get out of sync at some point and it would be easier to just point to the right file and explain from a high level what it is doing or what it is useful for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants