Codec input sanitization #427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreenVideo allocated more memory than necessary per block, and could run past EOF if the block was malformed. ScreenVideo2 had the same issues as ScreenVideo, but calculated blockHeight and blockWidth incorrectly due to missing (). ExtendedAudio did not rewind the pointer if it decided it couldn't handle the audio, and could cause an NPE on an unknown or invalid fourcc value. AV1Video always thought data passed to it was AV1 data rather than checking the fourcc value. MPEG1Video had the opposite problem, it looked to see if the data was AVC video data then tried to parse it as though it were MPEG1, and threw away the first configuration packet because decoderConfiguration wasn't initialized on the first pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit from kdkd fork
272502dCodec sanitization
ScreenVideo allocated more memory than necessary per block, and could run past EOF if the block was malformed.
ScreenVideo2 had the same issues as ScreenVideo, but calculated blockHeight and blockWidth incorrectly due to missing ().
ExtendedAudio did not rewind the pointer if it decided it couldn't handle the audio, and could cause an NPE on an unknown or invalid fourcc value.
AV1Video always thought data passed to it was AV1 data rather than checking the fourcc value.
MPEG1Video had the opposite problem, it looked to see if the data was AVC video data then tried to parse it as though it were MPEG1, and threw away the first configuration packet because decoderConfiguration wasn't initialized on the first pass.