fix: resolve Vitest TDZ on NiceNavigationItemRef initialization#5
Open
gabrielroberge wants to merge 1 commit into
Open
fix: resolve Vitest TDZ on NiceNavigationItemRef initialization#5gabrielroberge wants to merge 1 commit into
gabrielroberge wants to merge 1 commit into
Conversation
…roved dependency injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
ReferenceError: Cannot access 'NiceNavigationItemRef' before initializationoccurring under Vitest when a consumer project loads the package TypeScript sources through sourcemaps.ng serve/ng buildwere not impacted.Problem
Two combined causes in the navigation module graph:
1. TDZ in
NiceNavigationItemsRendererSignal field initializers access
NiceNavigationItemRefduring class evaluation:Angular metadata already used
forwardRef, but the compiled field initializers did not.2. Runtime import cycle
Changes
navigation-items.tsforwardReftocontentChildrenandinject.navigation-item-ref.tsNiceNavigationruntime import withNiceNavigationItemsRenderer.forwardReftoinjectto break the runtime cycle down to 3 files.Impact
ng serve/ng build.Note:
This bug is not reproducible through
ng testinside the library itself because@angular/build:unit-testbundles all sources into a single Vite chunk, masking the ESM initialization-order issue.