Conversation
Add new Surface Laptop 8 Intel, Surface Laptop 8 Snapdragon, and Surface Laptop 13in 1st Intel driver pack records. Add Surface catalog maintenance guidance and remove the legacy Surface XML snapshot now superseded by surface.json.
There was a problem hiding this comment.
Pull request overview
Updates the OSDCloud Surface driver pack catalog by adding new Surface Laptop models to surface.json, introducing a reusable Copilot skill + guidance for maintaining that catalog, and removing the legacy surface.xml snapshot. This aligns the module’s driver pack source of truth with the JSON-based workflow and publishes the change as version 26.8.3.1.
Changes:
- Added new Surface driver pack entries (Surface Laptop 8 Intel, Surface Laptop 8 Snapdragon, Surface Laptop 13in 1st Intel) and renamed the existing 13in Snapdragon entry for naming consistency.
- Added an
add-surface-modelCopilot skill with a template and documented catalog maintenance/validation rules. - Removed
surface.xmland bumped module version + changelog for26.8.3.1.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OSDCloud/OSDCloud.psd1 | Bumps module manifest version to 26.8.3.1. |
| OSDCloud/core/driverpacks/surface.xml | Removes legacy Surface driver pack snapshot. |
| OSDCloud/core/driverpacks/surface.json | Adds new Surface Laptop driver pack entries and renames the 13in Snapdragon model label. |
| CHANGELOG.md | Documents the 26.8.3.1 release: additions/changes/removals. |
| .github/skills/add-surface-model/SKILL.md | Adds the reusable Copilot skill instructions for adding/validating Surface catalog entries. |
| .github/skills/add-surface-model/references/surface-catalog-rules.md | Adds documented rules for field resolution, update page discovery, and validation. |
| .github/skills/add-surface-model/assets/surface-model-template.json | Adds a standard JSON entry template for consistent catalog updates. |
Comment on lines
487
to
488
| "CatalogVersion": "26.07.31", | ||
| "ReleaseDate": "26.02.24", |
|
|
||
| 1. Review the current catalog entry shape in `OSDCloud/core/driverpacks/surface.json` and use [the template](./assets/surface-model-template.json) for field order. | ||
| 2. Follow [the Surface catalog rules](./references/surface-catalog-rules.md) to resolve each property from Microsoft sources and local catalog conventions. | ||
| 3. Add or update one JSON object in `surface.json`, keeping entries sorted by `Model`. |
|
|
||
| ## Field Resolution | ||
|
|
||
| Use the current `surface.json` object order for every entry: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation