fix(ci): correct driverpack catalog paths in Dell, HP, and Lenovo update workflows - #2
Merged
Merged
Conversation
OSDeploy
marked this pull request as ready for review
June 12, 2026 05:21
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'update'
fix(ci): correct driverpack catalog paths in Dell, HP, and Lenovo update workflows
Jun 12, 2026
There was a problem hiding this comment.
Pull request overview
Fixes the Dell/HP/Lenovo GitHub Actions catalog update workflows to write and stage driver pack catalog files from the correct repository location (OSDCloud/catalogs/driverpack/), aligning them with the existing Microsoft Surface update workflow’s convention.
Changes:
- Updated Dell workflow to copy/read/add
OSDCloud\catalogs\driverpack\dell.xml/OSDCloud/catalogs/driverpack/dell.xml. - Updated HP workflow to copy/read/add
OSDCloud\catalogs\driverpack\hp.xml/OSDCloud/catalogs/driverpack/hp.xml. - Updated Lenovo workflow to copy/read/add
OSDCloud\catalogs\driverpack\lenovo.xml/OSDCloud/catalogs/driverpack/lenovo.xml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-catalog-dell.yaml | Corrects Dell catalog file path to the OSDCloud/catalogs/driverpack directory and stages the correct file for commits. |
| .github/workflows/update-catalog-hp.yaml | Corrects HP catalog file path to the OSDCloud/catalogs/driverpack directory and stages the correct file for commits. |
| .github/workflows/update-catalog-lenovo.yaml | Corrects Lenovo catalog file path to the OSDCloud/catalogs/driverpack directory and stages the correct file for commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dell, HP, and Lenovo catalog update workflows referenced
catalogs\driverpack\at the repo root — a path that doesn't exist. Catalog files live underOSDCloud\catalogs\driverpack\, as already used correctly by the Microsoft Surface workflow.Changes
.github/workflows/update-catalog-dell.yaml— replace allcatalogs\driverpack\dell.xmlrefs withOSDCloud\catalogs\driverpack\dell.xml.github/workflows/update-catalog-hp.yaml— same fix forhp.xml.github/workflows/update-catalog-lenovo.yaml— same fix forlenovo.xmlAll three workflows now align with the existing
update-catalog-microsoft.yamlconvention: