feat: add sync committee pool & GET /eth/v1/validator/sync_committee_contribution endpoint #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiroObiJohn
requested review from
Kayden-ML,
KolbyML,
syjn99 and
varun-doshi
as code owners
ShiroObiJohn
changed the title
…ontributions. get /eth/v1/validator/sync_committee_contribution endpoint
ShiroObiJohn
force-pushed
the
feat/beacon_api_validator_sync_committee_contribution
branch
from
8cb2bb6 to
41c1f07
Compare
Contributor
|
@shariqnaiyer can you give this a first look? |
Contributor
|
@ShiroObiJohn Do you plan to continue working on this PR? |
Contributor
|
Please implement the initial changes and I will review further. |
Contributor
|
As I have no received response from @ShiroObiJohn. I am closing this for now. Feel free to reopen it if you plan to continue working on it. |
Contributor
Author
|
@shariqnaiyer @KolbyML Can you help to reopen this PR? I rebased the code on latest master. |
Contributor
Author
|
@KolbyML @shariqnaiyer Should I create a new PR if this one can't be reopened? |
Contributor
Please make a new PR. Thank you! |
Contributor
Author
|
Thank you. I created another PR #880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #238
How was it fixed?
implemented GET /eth/v1/validator/sync_committee_contribution endpoint.
added sync committee pool to manage sync committee messages and contributions.
To-Do