Skip to content

Conversation

@syjn99
Copy link
Member

@syjn99 syjn99 commented Aug 25, 2025

What was wrong?

Fixes #744, and also matches with current lean specification (commit hash: e9bb80cb5fef3b6a1a2aae009a37cf86f002e431).

How was it fixed?

  • Did some double-check with current lean spec.
  • Changed history_length (= mcache_len) to 6.
  • Added docstrings with the specification link.

Note

I'm quite sure the networking part would need some changes:

  1. Use fork digest instead of devnet{N}: Agreed with @KolbyML's comment.
  2. Add topic for calculating message-id: Making it consistent with altair spec.

But I didn't include it in this PR.

To-Do

@syjn99 syjn99 requested review from Kayden-ML and unnawut August 25, 2025 13:28
@syjn99 syjn99 added the Lean label Aug 25, 2025
@syjn99 syjn99 changed the title chore: lean specification at e9bb80 chore: align lean specification with e9bb80 Aug 25, 2025
Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@KolbyML KolbyML added this pull request to the merge queue Aug 25, 2025
Merged via the queue into ReamLabs:master with commit f802e71 Aug 25, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove lean_* prefixes from gossipsub topic

2 participants