feat: add Checkpoint container and match with spec #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjn99
requested review from
Kayden-ML,
KolbyML and
varun-doshi
as code owners
syjn99
commented
Aug 14, 2025
Comment on lines
+199
to
+210
| while let Some(children) = children_map.get(¤t_root) { | ||
| current_root = *children | ||
| .iter() | ||
| .max_by_key(|child_hash| { | ||
| let vote_weight = vote_weights.get(*child_hash).unwrap_or(&0); | ||
| let slot = blocks.get(*child_hash).map(|block| block.slot).unwrap_or(0); | ||
| (*vote_weight, slot, *(*child_hash)) | ||
| }) | ||
| .ok_or_else(|| anyhow!("No children found for current root: {current_root}"))?; | ||
| } | ||
|
|
||
| Ok(current_root) |
Member
Author
There was a problem hiding this comment.
Note: I found my linter keeps complaining for this part, so I rewrite this more idiomatically
looks good
allnil
pushed a commit
to loadnetwork/ream
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Checkpointcontainer is missing, which is likely to be included in the spec.How was it fixed?
This PR adds
Checkpointcontainer and matches with the current (draft) spec. (leanEthereum/leanSpec#8)To-Do