-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add "zkvm" flag that reduces VariableList to a manageable size by zkVMs #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
84feed5
feat: add zkvm feature flag that reduces the list size
unnawut b8ee615
fix: remove quoted_u8_var_list from zkvm feature
unnawut 7d4ed02
docs: add rationale behind the zkvm feature flag
unnawut b4b84c1
fix: cargo formatting
unnawut c5629b3
fix: remaining formatting
unnawut 7a225c4
fix: formatting
unnawut 184c272
refactor: move zkvm feature flag into its own types
unnawut c4e80ae
fix: cargo fmt
unnawut d3f1e4d
Merge branch 'master' into zkvm
unnawut a336341
fix: add back quoted_u8_var_list removed by accident
unnawut 626dd60
fix: quoted_u8_var_list not implemented for MaxAttestationsPerEpoch
unnawut 1a782a8
fix: *_epoch_participation to use ValidatorRegistryLimit as per Altai…
unnawut 0bb0cf2
fix: switch remaining references of MaxAttestationsPerEpoch to Valida…
unnawut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #[cfg(feature = "zkvm")] | ||
| use ssz_types::typenum::U536870912; | ||
| #[cfg(not(feature = "zkvm"))] | ||
| use ssz_types::typenum::U1099511627776; | ||
|
|
||
| // MAX_ATTESTATIONS * SLOTS_PER_EPOCH | ||
| #[cfg(not(feature = "zkvm"))] | ||
| pub type MaxAttestationsPerEpoch = U1099511627776; | ||
| #[cfg(feature = "zkvm")] | ||
| pub type MaxAttestationsPerEpoch = U536870912; | ||
|
|
||
| // VALIDATOR_REGISTRY_LIMIT | ||
| #[cfg(not(feature = "zkvm"))] | ||
| pub type ValidatorRegistryLimit = U1099511627776; | ||
| #[cfg(feature = "zkvm")] | ||
| pub type ValidatorRegistryLimit = U536870912; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.