Skip to content

feat: feat: add CI that ream-consensus and ream-bls compiles to SP1 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kayden-ML merged 12 commits into from
Mar 3, 2025
Merged

feat: feat: add CI that ream-consensus and ream-bls compiles to SP1 #154

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5a4e5f4
feat: Add CI that compiles to SP1
Kayden-ML Mar 1, 2025
1414314
fix: changed name
Kayden-ML Mar 2, 2025
5a498e8
fix: testing
Kayden-ML Mar 2, 2025
67ff0df
fix: added to separate file
Kayden-ML Mar 2, 2025
734a076
fix: updated name to riscv5
Kayden-ML Mar 2, 2025
5b10e9b
fix: made v lowercase
Kayden-ML Mar 2, 2025
3399741
fix: updated name
Kayden-ML Mar 3, 2025
9ea9f46
fix: added new line
Kayden-ML Mar 3, 2025
5000dec
fix: removed needs
Kayden-ML Mar 3, 2025
2b80b3f
fix: removed file
Kayden-ML Mar 3, 2025
53e27ca
fix: added file back with updated name
Kayden-ML Mar 3, 2025
78c3688
fix: removed needs
Kayden-ML Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/riscV.yml
View file
Open in desktop
Copy link
Contributor

@KolbyML KolbyML Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make the V lowercase in the file and in the file name

Copy link
Contributor

@KolbyML KolbyML Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this files name still has a uppercase V

Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Riscv
Copy link
Contributor

@KolbyML KolbyML Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Riscv
name: RISC-V


on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

env:
CARGO_TERM_COLOR: always

jobs:
build-sp1:
runs-on: ubuntu-latest
needs: [cargo-fmt, cargo-clippy]
Copy link
Contributor

@KolbyML KolbyML Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the risc CI's are now not running?

trying removing the needs lines for both of them. I am guessing it is due to these jobs not being in the same file node


steps:
- name: Checkout Repository
uses: actions/checkout@v4

- name: Install toolchain
run: |
curl -L https://sp1up.succinct.xyz | bash
/home/runner/.sp1/bin/sp1up
rustup default succinct

- name: Build SP1
run: cargo build --target=riscv32im-succinct-zkvm-elf -p ream-consensus -p ream-bls

build-risc0:
runs-on: ubuntu-latest
needs: [cargo-fmt, cargo-clippy]

steps:
- uses: actions/checkout@v4

- name: Install toolchain
run: |
curl -L https://risczero.com/install | bash
/home/runner/.risc0/bin/rzup install
cargo risczero install
rustup default risc0

- name: Build Risc0
run: cargo build --target=riscv32im-risc0-zkvm-elf -p ream-consensus -p ream-bls

Copy link
Contributor

@KolbyML KolbyML Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a new line here
image

17 changes: 0 additions & 17 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,6 @@ env:
CARGO_TERM_COLOR: always

jobs:
build-risc0:
runs-on: ubuntu-latest
needs: [cargo-fmt, cargo-clippy]

steps:
- uses: actions/checkout@v4

- name: Install toolchain
run: |
curl -L https://risczero.com/install | bash
/home/runner/.risc0/bin/rzup install
cargo risczero install
rustup default risc0

- name: Build Risc0
run: cargo build --target=riscv32im-risc0-zkvm-elf -p ream-consensus -p ream-bls

cargo-fmt:
runs-on: ubuntu-latest

Expand Down