Skip to content

Conversation

@chetanyb
Copy link
Contributor

@chetanyb chetanyb commented Dec 28, 2025

What was wrong?

The recent migration to feature flags caused build failures for devnet2 due to implicit default features enabling devnet1 simultaneously.

How was it fixed?

  • Disables default-features for ream crates in the workspace Cargo.toml.
  • Explicitly propagates devnet1 and devnet2 flags through the dependency tree.
  • Updates bin/ream to correctly toggle features on its dependencies.
  • Added compile-time guards (compile_error!) in core crates to enforce mutual exclusivity and ensure either devnet1 or devnet2 is always selected.

This ensures cargo build --no-default-features --features devnet2 compiles correctly without conflicting definitions.

To-Do

@chetanyb chetanyb force-pushed the devnet2-compilation-fix branch from 6145796 to e790511 Compare December 28, 2025 21:56
Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you for the contribution :shipit:

@KolbyML KolbyML enabled auto-merge December 29, 2025 01:57
Copy link
Contributor

@Kayden-ML Kayden-ML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just fix ef tests from failing

@Kayden-ML Kayden-ML disabled auto-merge December 29, 2025 01:59
@Kayden-ML Kayden-ML force-pushed the devnet2-compilation-fix branch 6 times, most recently from 8722e43 to a03866a Compare December 29, 2025 04:44
@Kayden-ML Kayden-ML force-pushed the devnet2-compilation-fix branch from a03866a to 09018a6 Compare December 29, 2025 05:04
@Kayden-ML Kayden-ML enabled auto-merge December 29, 2025 05:08
@Kayden-ML Kayden-ML added this pull request to the merge queue Dec 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 29, 2025
* fix(build): resolve feature flag conflicts for devnet2 compilation

* fix: fix sort and fmt

---------

Co-authored-by: Kayden Moroz Liebl <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 29, 2025
@KolbyML KolbyML merged commit 6b5b179 into ReamLabs:master Dec 29, 2025
14 checks passed
@chetanyb chetanyb deleted the devnet2-compilation-fix branch December 29, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants