Skip to content

Conversation

@shariqnaiyer
Copy link
Contributor

No description provided.

@unnawut
Copy link
Collaborator

unnawut commented May 17, 2025

@shariqnaiyer Please check the build failure. This is its first run after merging the build check PR so please let us know if you find anything odd

@shariqnaiyer
Copy link
Contributor Author

shariqnaiyer commented May 17, 2025

@unnawut As soon as I fetched the upstream branch a style change in the components/ui/button.tsx appeared. At first I did not push this change but then I found the ubuntu test failing due to that file so I did push that change.

The windows check is finding style issues in 33 files across the codebase. I believe this is unexpected behavior as the macos and ubuntu checks are passing.

@shariqnaiyer
Copy link
Contributor Author

@unnawut This likely is due to the difference in how windows and linux systems deal with line endings.

I wouldn't think it would be possible to pass all checks if that is the case. Do let me know what you think.

@unnawut
Copy link
Collaborator

unnawut commented May 19, 2025

@shariqnaiyer yeah building on all of ubuntu/win/mac is an overkill. I've reduced to ubuntu only. Can you try again?

@shariqnaiyer
Copy link
Contributor Author

@unnawut This seems to work.

@unnawut
Copy link
Collaborator

unnawut commented May 19, 2025

Can you rebase master once more? I've pushed the missing prettifier changes to master so we don't pollute this PR.

@shariqnaiyer
Copy link
Contributor Author

There we go!

@unnawut
Copy link
Collaborator

unnawut commented May 19, 2025

Thanks for your help!

@unnawut unnawut merged commit 8c9f45f into ReamLabs:master May 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants