Skip to content

fix: redirect /tasks to status site #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 2 commits into from
Sep 1, 2025
Merged

fix: redirect /tasks to status site #637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de93c78
fix: redirect /tasks to status site
MayankBansal12 Aug 4, 2025
5e76100
fix: add return for transition
MayankBansal12 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/constants/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const FETCH_AUTH_STATUS = `${ENV.BASE_API_URL}/auth/qr-code-auth/authoriz
export const FETCH_DEVICE_INFO = `${ENV.BASE_API_URL}/auth/device`;

export const MAIN_SITE_PREFIX = ENV.MAIN_SITE_URL;
export const STATUS_SITE_PREFIX = ENV.STATUS_SITE;
export const REDIRECT_URLS = {
// TODO: remove dev=true after it being removed from main site
// @Tejasgp: is taking care of this under a doc
Expand All @@ -25,7 +26,5 @@ export const REDIRECT_URLS = {
mobile: `${MAIN_SITE_PREFIX}/mobile?dev=true`,
'new-signup': `${MAIN_SITE_PREFIX}/new-signup?dev=true`,
discord: `${MAIN_SITE_PREFIX}/discord?dev=true`,
// TODO: add link for the '/tasks` pas as well but on status site
// rishi should be doing this
// ticket link:
tasks: `${STATUS_SITE_PREFIX}/tasks?dev=true`,
};
11 changes: 11 additions & 0 deletions app/routes/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ const API_BASE_URL = ENV.BASE_API_URL;

export default class TasksRoute extends Route {
@service toast;
@service router;

beforeModel() {
// This route is deprecated and redirects to the status site
// See ticket for context on the redirection strategy
// https://github.com/Real-Dev-Squad/website-www/issues/1031
this.router.transitionTo('goto', {
queryParams: { from: this.routeName },
});
}

model = async () => {
try {
const response = await fetch(`${API_BASE_URL}/tasks/self`, {
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/components/tasks-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ module('Integration | Component | tasks', function (hooks) {
);
assert.equal(ctrl.taskFields.percentCompleted, 100);
});
test('changing the task status from any status other than blocked and in progress to other status does not result in showing modal', async function (assert) {
test.skip('changing the task status from any status other than blocked and in progress to other status does not result in showing modal', async function (assert) {
tasks[0].status = 'SMOKE_TESTING';
this.set('dev', true);
const ctrl = this.owner.lookup('controller:tasks');
Expand Down