generated from RealDevSquad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 64
Added notification link in dropdown #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RohitKuwar
wants to merge
8
commits into
develop
Choose a base branch
from
RohitKuwar-patch-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5b9d24e
Added notification link in dropdown
RohitKuwar 033f144
css for notification
RohitKuwar 68060f9
Added notification page
RohitKuwar be6949b
Added notification page
RohitKuwar 0555b29
Added dummy notification data for temporary
RohitKuwar 2eefdac
Added notification page
RohitKuwar 105adee
Added notification page
RohitKuwar 7408e2b
Added notification page
RohitKuwar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| import React from 'react'; | ||
| import personData from '../mock/person.json'; | ||
| import NavBar from '@components/NavBar'; | ||
|
|
||
| export default function notification() { | ||
| return ( | ||
| <div className="container"> | ||
| <NavBar personData={personData} /> | ||
| <div className="notification"> | ||
| <ul> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <style jsx> | ||
| {` | ||
| .notification { | ||
| margin: auto; | ||
| padding: 0; | ||
| width: 50%; | ||
| min-height: auto; | ||
| border: 0.15em solid rgba(128, 128, 128, 0.5); | ||
| } | ||
| .notification ul { | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| .notification ul li { | ||
| list-style-type: none; | ||
| border-bottom: 0.1em solid rgba(128, 128, 128, 0.137); | ||
| padding: 5px; | ||
| } | ||
| .notification ul li:hover { | ||
| background-color: rgba(214, 212, 212, 0.308); | ||
| } | ||
| .notificationArea h4 { | ||
| margin: 0; | ||
| padding: 10px; | ||
| } | ||
| .buttons { | ||
| margin-left: 0.5em; | ||
| } | ||
| .approve { | ||
| background-color: #2ecc71; | ||
| text-align: center; | ||
| border: none; | ||
| outline: none; | ||
| cursor: pointer; | ||
| padding: 0.5em; | ||
| border-radius: 0.3em; | ||
| font-weight: 600; | ||
| } | ||
| .discard { | ||
| background-color: #ff3838; | ||
| text-align: center; | ||
| border: none; | ||
| outline: none; | ||
| cursor: pointer; | ||
| padding: 0.5em; | ||
| border-radius: 0.3em; | ||
| font-weight: 600; | ||
| margin-left: 0.5em; | ||
| } | ||
| @media only screen and (max-width: 600px) { | ||
| .notification { | ||
| width: 80%; | ||
| margin-top: 3em; | ||
| } | ||
| } | ||
| `} | ||
| </style> | ||
| </div> | ||
| ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please refactor this?
lihas a similar pattern throughout. Maybe create a new function that returns thisliand call that function 4-5 times, or create a component and call that component 4-5 times.That will make this code much more clean and readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thnks. I will make the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumitd94 Changes has been made. Please check.