- #2661
Closed
- #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suojae
force-pushed
the
fix/async-sequence-background-thread
branch
2 times, most recently
from
934600d to
3ff3f15
Compare
suojae
force-pushed
the
fix/async-sequence-background-thread
branch
from
3ff3f15 to
b0e5e21
Compare
suojae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2553
Problem Description
The current implementation of
AsyncSequence.asObservable()can potentially execute on the main thread, which may cause UI blocking issues. This becomes especially problematic when the AsyncSequence performs time-consuming operations.Changes
Modified
AsyncSequence.asObservable()to useTask.detached, ensuring the sequence always runs on a background thread. This change guarantees that AsyncSequence operations won't block the main thread.Testing