Fix combinations of concentration ranges for RMG SA #131
Conversation
alongd
force-pushed
the
c_conc_in_sim
branch
2 times, most recently
from
d163293 to
8cc2d23
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| temperature=(500.0, 'K'), | ||
| pressure=(1.0, 'bar'), | ||
| initialMoleFractions={ | ||
| 'FA': 4.0, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| initialMoleFractions={ | ||
| 'FA': 4.0, | ||
| 'N2': 3.76, | ||
| 'FA': 2.5, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| temperature=(500.0, 'K'), | ||
| pressure=(10.0, 'bar'), | ||
| initialMoleFractions={ | ||
| 'FA': 4.0, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| initialMoleFractions={ | ||
| 'FA': 4.0, | ||
| 'N2': 3.76, | ||
| 'FA': 2.5, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| temperature=(500.0, 'K'), | ||
| pressure=(100.0, 'bar'), | ||
| initialMoleFractions={ | ||
| 'FA': 4.0, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| initialMoleFractions={ | ||
| 'FA': 4.0, | ||
| 'N2': 3.76, | ||
| 'FA': 2.5, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| temperature=(2000.0, 'K'), | ||
| pressure=(10.0, 'bar'), | ||
| initialMoleFractions={ | ||
| 'FA': 4.0, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| initialMoleFractions={ | ||
| 'FA': 4.0, | ||
| 'N2': 3.76, | ||
| 'FA': 2.5, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| temperature=(2000.0, 'K'), | ||
| pressure=(100.0, 'bar'), | ||
| initialMoleFractions={ | ||
| 'FA': 4.0, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
| initialMoleFractions={ | ||
| 'FA': 4.0, | ||
| 'N2': 3.76, | ||
| 'FA': 2.5, |
Check warning
Code scanning / CodeQL
Duplicate key in dict literal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 73.46% 75.30% +1.83%
==========================================
Files 22 24 +2
Lines 2891 3317 +426
Branches 762 854 +92
==========================================
+ Hits 2124 2498 +374
- Misses 552 586 +34
- Partials 215 233 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For use case #3 of this method
2 participants
Fixes the
get_species_concentration_lists_from_ranged_params()method inRMGConstantTP(), adding tests for the different use cases.