Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Purge temp files #332

Closed
wants to merge 1 commit into from
Closed

fix: Purge temp files #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/app/revanced/cli/command/PatchCommand.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ internal object PatchCommand : Runnable {
// region Save
apk.copyTo(temporaryFilesPath.resolve(apk.name), overwrite = true).apply {
patcherResult.applyTo(this)
patcherResult.dexFiles.forEach{it.stream.close()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it.use {} should be used in the applyTo function in ReVanced Library instead so it auto closes after using the stream, but I am not sure if closing the streams is applyTo's job. I think a better approach would be to return files instead of opening streams to them so that one can open streams for it at any time

}.let { patchedApkFile ->
if (!mount) {
ApkUtils.signApk(
Expand Down