Skip to content

Commit

Permalink
Mark required and optional fields, fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
katamatata committed Dec 1, 2022
1 parent 84d0034 commit f8ab464
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ interface Props {
const validationSchema = Yup.object({
mentee_mentoringGoal: Yup.string()
.nullable()
.required('Select a mentoring goal'),
.required('Please select a mentoring goal'),
mentee_primaryRole_fieldOfExpertise: Yup.string()
.nullable()
.required('Select a role'),
.required('Please select a role'),
mentee_overarchingMentoringTopics: Yup.array().max(
3,
'You can select up to three topics'
Expand Down Expand Up @@ -116,7 +116,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Goal</Caption>
<FormSelect
label="The most important goal you would like to adress with your mentor"
label="The most important goal to address with your mentor*"

This comment has been minimized.

Copy link
@ericbolikowski

ericbolikowski Dec 1, 2022

Contributor

Good stuff, simple and effective way of solving addressing this

name="mentee_mentoringGoal"
placeholder="Select..."
items={formMentoringGoals}
Expand All @@ -126,7 +126,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Topics</Caption>
<FormSelect
label="General topics you would like to me mentored on"
label="General topics you would like to be mentored on (optional)"
name="mentee_overarchingMentoringTopics"
placeholder="Select..."
items={formMentoringTopicsInGroup('overarchingTopics')}
Expand All @@ -141,7 +141,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Primary role</Caption>
<FormSelect
label="The primary role you would like to be mentored on."
label="The primary role you would like to be mentored on*"
name="mentee_primaryRole_fieldOfExpertise"
placeholder="Select..."
items={formFieldsOfExpertise}
Expand All @@ -151,7 +151,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Skills</Caption>
<FormSelect
label="Role-related skills you would like to mentored on (optional)"
label="Role-related skills you would like to be mentored on (optional)"
name="mentee_primaryRole_mentoringTopics"
placeholder="Select..."
disabled={
Expand All @@ -171,7 +171,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Secondary role</Caption>
<FormSelect
label="The secondary role you would like to be mentored on."
label="The secondary role you would like to be mentored on (optional)"
name="mentee_secondaryRole_fieldOfExpertise"
placeholder="Select..."
items={formFieldsOfExpertise}
Expand All @@ -181,7 +181,7 @@ const EditableMentoringGoalTopics = ({ profile, profileSaveStart }: Props) => {
<Columns.Column size={6}>
<Caption>Skills</Caption>
<FormSelect
label="Role-related skills you would like to mentored on (optional)"
label="Role-related skills you would like to be mentored on (optional)"
name="mentee_secondaryRole_mentoringTopics"
placeholder="Select..."
disabled={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ const ReadMentoringGoalTopics = ({ profile, caption }: ReadMentoringProps) => {
<CardTags items={[MENTORING_GOALS[mentee_mentoringGoal]]} />
) : (
<Placeholder>
The most important goal you would like to adress with your
mentor
The most important goal to address with your
mentor.
</Placeholder>
)}
</Columns.Column>
Expand All @@ -53,7 +53,7 @@ const ReadMentoringGoalTopics = ({ profile, caption }: ReadMentoringProps) => {
/>
) : (
<Placeholder>
General topics you would like to me mentored on
General topics you would like to be mentored on.
</Placeholder>
)}
</Columns.Column>
Expand Down Expand Up @@ -84,7 +84,7 @@ const ReadMentoringGoalTopics = ({ profile, caption }: ReadMentoringProps) => {
/>
) : (
<Placeholder>
Role-related skills you would like to mentored on (optional)
Role-related skills you would like to be mentored on.
</Placeholder>
)}
</Columns.Column>
Expand All @@ -93,7 +93,7 @@ const ReadMentoringGoalTopics = ({ profile, caption }: ReadMentoringProps) => {
<Element className="block-thicker-separator-dashed">
<Columns>
<Columns.Column size={6}>
<Caption>Secondary role (optional)</Caption>
<Caption>Secondary role</Caption>
{mentee_secondaryRole_fieldOfExpertise ? (
<CardTags
items={[
Expand All @@ -115,7 +115,7 @@ const ReadMentoringGoalTopics = ({ profile, caption }: ReadMentoringProps) => {
/>
) : (
<Placeholder>
Role-related skills you would like to mentored on (optional)
Role-related skills you would like to be mentored on.
</Placeholder>
)}
</Columns.Column>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const ReadToolsAndFrameworks = ({ profile, caption }: ReadMentoringProps) => {
/>
) : (
<Placeholder>
Please select tool and technologies you are particularly interested in
Please select tools and technologies you are particularly interested in
(max 3).
</Placeholder>
)}
Expand Down

0 comments on commit f8ab464

Please sign in to comment.