Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hero-section navbar-section about-page immplimented #28

Merged
merged 11 commits into from
Sep 1, 2021
Merged

Conversation

AbduallahBarmu
Copy link
Collaborator

close #22
close #11
clsoe #4

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for choose-wisely ready!

🔨 Explore the source changes: 7e3c60f

🔍 Inspect the deploy log: https://app.netlify.com/sites/choose-wisely/deploys/612f996d3817b30007b784b0

😎 Browse the preview: https://deploy-preview-28--choose-wisely.netlify.app/

<div className="hero_contant">
<div className="hero_title">
<h1>
The Only Place for <br />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should be imported from translation files

<span> {t("navbar.blog")}</span>
<span className="dot"></span>
</Nav.Link>
<Button className="nav__btn">Sign up</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is should be coming from translation

Copy link
Collaborator

@MohammedZakaria2 MohammedZakaria2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ammar-64 Ammar-64 merged commit 2d4aa43 into dev Sep 1, 2021
@Ammar-64 Ammar-64 deleted the final-features branch September 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about-page navbar
3 participants