Homepage headers fix#163
Open
jennetturkkan wants to merge 3 commits into
Open
Conversation
jennetturkkan
added
the
Refactor
jennetturkkan
requested review from
Jamil-Bailony,
hiba-machfej,
louisrli and
mohammad-jundi
louisrli
reviewed
Nov 22, 2020
louisrli
left a comment
louisrli
left a comment
Contributor
There was a problem hiding this comment.
this ones a little big/risky for post code-freeze since it touches all components (similar to jamils desire to refactor all his components), if this is purely a code cleanup you can leave this PR open for after the graduation and submit it
Collaborator
Author
|
yes, I didn't do anything except of creating main and secondary header mixins and including it to h2 and h6 |
Jamil-Bailony
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@louisrli I created mixin for headers to make code cleaner, since we were repeating this code in many files.