Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#42 test fix #52

Merged
merged 38 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
86155c6
refactor(MockTime): ๋ถˆํ•„์š”ํ•œ ์ƒ์„ฑ์ž์— private ํ•œ์ •์ž ์‚ญ์ œ
mjj111 Feb 10, 2024
40c8e24
feat(SuccessResponse): ๋ฐ˜ํ™˜๊ฐ์ฒด ์ƒ์„ฑ
mjj111 Feb 12, 2024
f8dab73
remove: ๋ฐ˜ํ™˜๊ฐ์ฒด ์ƒ์„ฑ์œผ๋กœ ์ธํ•œ ์‚ญ์ œ
mjj111 Feb 12, 2024
63e7ad4
feat(DummyGenerator) : ๋”๋ฏธ ๋ฐ์ดํ„ฐ๋ฅผ ์ƒ์„ฑํ•˜๋Š” ๊ฐ์ฒด ๊ตฌํ˜„
mjj111 Feb 12, 2024
a9791b9
style(BaseServiceTest) : ๋”๋ฏธ ๋ฐ์ดํ„ฐ ๊ฐ์ฒด ์ถ”๊ฐ€๋กœ ์ธํ•œ ์ƒ์ˆ˜ ์ถ”๊ฐ€, ๋ฐ ์˜์กด๊ฐ์ฒด ๋‚˜์—ด ์ˆœ์„œ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
9a8f4c6
refactor(docTests) : Doc ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ฃผ์„์ฒ˜๋ฆฌ
mjj111 Feb 12, 2024
7c30e0c
feat(EmailSuccess) : ์ด๋ฉ”์ผ ๊ด€๋ จ ์„ฑ๊ณต์ฝ”๋“œ ์ถ”๊ฐ€
mjj111 Feb 12, 2024
26e1211
refactor(WebSocketTest) : ๋”๋ฏธ ๋ฐ์ดํ„ฐ๋ฅผ ํ†ตํ•ด ์‹ค์ œ๋กœ ์ ‘๊ทผํ•˜๋„๋ก ํ—ค๋”๋ฅผ ์‚ฝ์ž… ๋ฐ Mock ๊ฐ์ฒด ๋Œ€์ฒด
mjj111 Feb 12, 2024
af99187
refactor(response) : ๊ฒฐ๊ณผ ๊ฐ์ฒด๋ฅผ global ๋””๋ ‰ํ† ๋ฆฌ์—์„œ ์ด๋™ํ•จ์— ๋”ฐ๋ฅธ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
07c02c8
refactor(time) : ๊ฐ€๋…์„ฑ์„ ์œ„ํ•ด time์— ๋Œ€ํ•œ ์˜์—ญ์œผ๋กœ ํŒ๋‹จํ•  ์ˆ˜ ์žˆ๋„๋ก time ๋””๋ ‰ํ† ๋ฆฌ๋กœ ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
068d559
refactor(MessageSendRequest) : String์œผ๋กœ ๋ฐ›๋˜ ๊ฐ’์„ enum ์œผ๋กœ ๋ฐ›๋„๋ก ์ˆ˜์ •
mjj111 Feb 12, 2024
e6b3244
refactor(Message) : enum์„ ๋ฐ›๋Š” controller ์—์„œ ์ž…๋ ฅ ์˜ˆ์™ธ๋ฅผ ์ฒ˜๋ฆฌํ•˜๋„๋ก ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
74f30dd
refactor(MemberDocTest) : Doc ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ฃผ์„์ฒ˜๋ฆฌ
mjj111 Feb 12, 2024
8556edb
refactor(SuccessResponse) : ๊ฒฐ๊ณผ ๊ฐ์ฒด ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•œ ์ฝ”๋“œ ์ˆ˜์ •
mjj111 Feb 12, 2024
7217245
refactor(AuthServiceTest) : ๋”๋ฏธ๋ฐ์ดํ„ฐ ์ƒ์„ฑ ๊ฐ์ฒด๋กœ ์ธํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ˆ˜์ •
mjj111 Feb 12, 2024
86546e5
style(DatabaseCleanup) : ํ•„์š”์—†๋Š” import ๋ฌธ ์‚ญ์ œ
mjj111 Feb 12, 2024
30787fb
refactor(ChatReportRequest) : request์—์„œ enum ๊ฐ’์„ ๋ฐ›๋„๋ก ์ˆ˜์ •
mjj111 Feb 12, 2024
ef78c37
style(AwsS3UploaderServiceTest) : BaseTest์—์„œ @SpringBoot ์• ๋„ˆํ…Œ์ด์…˜์„ ๊ฐ–๊ณ  ์žˆ๊ธฐโ€ฆ
mjj111 Feb 12, 2024
e6466c5
refatctor(block) : Chatting ๋„๋ฉ”์ธ์—์„œ ๋ถ„๋ฆฌํ•˜๊ธฐ ์œ„ํ•œ ํด๋ž˜์Šค ์ž‘์„ฑ ๋ฐ ์‚ญ์ œ
mjj111 Feb 12, 2024
3c5b56d
style(MemberInfoServiceTest) : BaseTest ์ƒ์†ํ•จ์— ๋”ฐ๋ฅธ @SpringBoot ์• ๋„ˆํ…Œ์ด์…˜ ์‚ญ์ œ โ€ฆ
mjj111 Feb 12, 2024
1bfb467
style(MatchingApplicationService) : private ๋ฉ”์„œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” public ๋ฉ”์„œ๋“œ ์•„๋ž˜๋กœ ์ด๋™
mjj111 Feb 12, 2024
9c72755
refactor(MatchingApplicationServiceTest) : ๋””๋ ‰ํ† ๋ฆฌ ๋ณ€๊ฒฝ์œผ๋กœ์ธํ•œ ์ˆ˜์ •
mjj111 Feb 12, 2024
779faf3
refactor(MatchingBusinessTest) : MatchingApplicationGenerator ๋ฅผ Dummyโ€ฆ
mjj111 Feb 12, 2024
21e69ba
feat(Member) : Chat ๋„๋ฉ”์ธ์—์„œ ์‚ฌ์šฉ๋˜๋Š” get ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€
mjj111 Feb 12, 2024
b3521b7
style(socket) : ์†Œ์ผ“๊ณผ ๊ด€๋ จ๋œ ์ฝ”๋“œ๋ฅผ ๋ช…์‹œ์ ์œผ๋กœ ๊ตฌ๋ถ„ํ•˜๊ธฐ ์œ„ํ•ด ๋””๋ ‰ํ† ๋ฆฌ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
4f1058a
refactor(ChatReport,ChatRoom) : ๋ฉค๋ฒ„ ๊ฐ์ฒด์™€ ์—ฐ๊ด€๊ด€๊ณ„ ์ถ”๊ฐ€
mjj111 Feb 12, 2024
cacd90b
refactor(ChatReportService) : ๋ฉค๋ฒ„ ๊ฐ์ฒด์™€ ์—ฐ๊ด€๊ด€๊ณ„ ์ถ”๊ฐ€๋กœ ์ธํ•œ ์ฝ”๋“œ ์ˆ˜์ •
mjj111 Feb 12, 2024
0a1bc41
refactor(ChatReportServiceTest) : ์‹ค์ œ ๋ฉค๋ฒ„๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ์ˆ˜์ • ๋ฐ BaseTest ์ƒ์† ์ถ”๊ฐ€
mjj111 Feb 12, 2024
28f1d09
refactor(ChatServiceTest) : messageRepository๋ฅผ MockBean์œผ๋กœ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ธฐ ์œ„ํ•ด โ€ฆ
mjj111 Feb 12, 2024
905fd25
refactor(EmailSenderTest, EventPublisherTest) : BaseServiceTest์—์„œ @Spโ€ฆ
mjj111 Feb 12, 2024
b5db37b
remove(MatchingApplicationGenerator) : DummyGenerator ๊ฐ์ฒด ์ƒ์„ฑ์— ๋”ฐ๋ฅธ ์‚ญ์ œ
mjj111 Feb 12, 2024
9417cf3
remove(MatchingApplicationApiTest) : ๋‹จ์ผ๋กœ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ๋™์ž‘ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ƒˆ๋กœ ์ฝ”๋“œ ์ž‘์„ฑ
mjj111 Feb 12, 2024
288f7b4
style(BlockServiceTest) : ํ•„์š”์—†๋Š” ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
c703663
style(AuthServiceTest, EmailServiceTest) : ํ•„์š”์—†๋Š” ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
8ff4c13
style(AwsS3UploaderTest, EmailSenderTest) : ํ•„์š”์—†๋Š” ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ
mjj111 Feb 12, 2024
aebc863
refactor(interceptor) : config ๋””๋ ‰ํ† ๋ฆฌ๋กœ ์ด๋™
mjj111 Feb 12, 2024
c7ce85f
chore : fcm ๊ด€๋ จ ์„ค์ • ์ถ”๊ฐ€
mjj111 Feb 12, 2024
b20c336
chore : Git Actions์— JSON ์‚ฌ์šฉ๋ถˆ๊ฐ€ ์ด์Šˆ ํ•ด๊ฒฐ
suhyun0918 Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/test-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,20 @@ jobs:
touch ./application-secret.yml
echo "${{ secrets.APPLICATION_SECRET }}" > ./application-secret.yml

- name: firebase_service_key.json ํŒŒ์ผ ์ƒ์„ฑ
id: create-json
uses: jsdaniell/[email protected]
with:
name: "firebase_service_key.json"
json: ${{ secrets.FCM_KEY }}


- name: JSON ํŒŒ์ผ ์ด๋™ ๋ฐ ๋กœ๊ทธ ํ™•์ธ
run: |
mv ./firebase_service_key.json ./src/main/resources/firebase_service_key.json
cd ./src/main/resources
ls -a .

- name: Gradle ๊ถŒํ•œ ํ—ˆ์šฉ
run: chmod +x gradlew
- name: PR ๋ฐ PUSH ์ „, ํ…Œ์ŠคํŠธ ํ™•์ธ
Expand Down
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ง์”€ํ•˜์‹  ๋Œ€๋กœ ์ˆ˜์ • ํ•ด์ฃผ์…จ๊ตฐ์š” ! ์ปจ๋ฒค์…˜์œผ๋กœ ํ™œ์šฉํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค

Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
import com.aliens.backend.auth.service.AuthService;
import com.aliens.backend.auth.controller.dto.AuthToken;
import com.aliens.backend.auth.controller.dto.LoginRequest;
import com.aliens.backend.global.success.AuthSuccessCode;
import com.aliens.backend.global.success.SuccessResponse;
import com.aliens.backend.global.success.SuccessResponseWithoutResult;
import org.springframework.http.ResponseEntity;
import com.aliens.backend.global.response.success.AuthSuccess;
import com.aliens.backend.global.response.SuccessResponse;
import org.springframework.web.bind.annotation.*;


Expand All @@ -20,17 +18,29 @@ public AuthController(final AuthService authService) {
}

@PostMapping
public ResponseEntity<?> login(@RequestBody final LoginRequest loginRequest) {
return SuccessResponse.toResponseEntity(AuthSuccessCode.GENERATE_AUTHTOKEN_SUCCESS, authService.login(loginRequest));
public SuccessResponse<AuthToken> login(@RequestBody final LoginRequest loginRequest) {

return SuccessResponse.of(
AuthSuccess.GENERATE_TOKEN_SUCCESS,
authService.login(loginRequest)
);
}

@PostMapping("/logout")
public ResponseEntity<?> logout(@RequestBody final AuthToken authToken) {
return SuccessResponseWithoutResult.toResponseEntity(AuthSuccessCode.LOGOUT_SUCCESS);
public SuccessResponse<String> logout(@RequestBody final AuthToken authToken) {

return SuccessResponse.of(
AuthSuccess.LOGOUT_SUCCESS,
authService.logout(authToken)
);
}

@PostMapping("/reissue")
public ResponseEntity<?> reissue(@RequestBody final AuthToken authToken) {
return SuccessResponse.toResponseEntity(AuthSuccessCode.REISSUE_AUTHTOKEN_SUCCESS, authService.reissue(authToken));
public SuccessResponse<AuthToken> reissue(@RequestBody final AuthToken authToken) {

return SuccessResponse.of(
AuthSuccess.REISSUE_TOKEN_SUCCESS,
authService.reissue(authToken)
);
}
}
4 changes: 4 additions & 0 deletions src/main/java/com/aliens/backend/auth/domain/Member.java
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ public void changeProfileImage(final S3File newFile) {
image.change(newFile);
}

public Long getId() {
return id;
}

@Override
public String toString() {
return String.format("email: %s, role : %s", this.email, this.role);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import com.aliens.backend.auth.domain.*;
import com.aliens.backend.auth.domain.repository.MemberRepository;
import com.aliens.backend.auth.domain.repository.TokenRepository;
import com.aliens.backend.global.error.MemberError;
import com.aliens.backend.global.error.TokenError;
import com.aliens.backend.global.response.error.MemberError;
import com.aliens.backend.global.response.error.TokenError;
import com.aliens.backend.global.exception.RestApiException;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.aliens.backend.auth.service;

import com.aliens.backend.global.error.MemberError;
import com.aliens.backend.global.response.error.MemberError;
import com.aliens.backend.global.exception.RestApiException;
import com.aliens.backend.global.property.PasswordEncodeProperties;
import org.springframework.stereotype.Component;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.aliens.backend.auth.controller.dto.LoginMember;
import com.aliens.backend.auth.domain.MemberRole;
import com.aliens.backend.global.error.TokenError;
import com.aliens.backend.global.response.error.TokenError;
import com.aliens.backend.global.exception.RestApiException;
import com.aliens.backend.global.property.JWTProperties;
import io.jsonwebtoken.Claims;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package com.aliens.backend.block.controller;

import com.aliens.backend.auth.controller.dto.LoginMember;
import com.aliens.backend.block.controller.dto.BlockRequest;
import com.aliens.backend.block.service.BlockService;
import com.aliens.backend.global.config.resolver.Login;
import com.aliens.backend.global.response.SuccessResponse;
import com.aliens.backend.global.response.success.ChatSuccess;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;

@RestController
public class BlockController {

private final BlockService blockService;

public BlockController(BlockService blockService) {
this.blockService = blockService;
}

@PostMapping("/chat/block")
public SuccessResponse<String> blockPartner(@Login LoginMember loginMember,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฉค๋ฒ„๋„ ๋ณ€ํ™˜ํ•ด์ฃผ์…จ๋„ค์š”! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜ํ˜„๋‹˜๊ป˜์„œ ์ž‘์„ฑํ•˜์‹  ๋ฆฌ๋ทฐ์—์„œ ์ฒ˜๋Ÿผ, ์•„์ง @Login ์—์„œ Long memberId๋ฅผ ๋ฐ›๊ณ  ์žˆ๋Š” ์ปจํŠธ๋กค๋Ÿฌ๋„ ์žˆ์Šต๋‹ˆ๋‹ค!
์ตœ์†Œํ•œ์œผ๋กœ ์ˆ˜์ •ํ•˜๊ณ ์žํ•ด์„œ ํ”ผ๋“œ๋ฐฑ ๋ฐ›์œผ์‹  ๋ถ€๋ถ„๋“ค ๋‹ค์‹œ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ™‡โ€โ™‚๏ธ

@RequestBody BlockRequest request) {
return SuccessResponse.of(
ChatSuccess.BLOCK_SUCCESS,
blockService.blockPartner(loginMember, request)
);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package com.aliens.backend.block.controller.dto;

public record BlockRequest(Long partnerId, Long chatRoomId) {
}
30 changes: 30 additions & 0 deletions src/main/java/com/aliens/backend/block/domain/Block.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatBlock -> Block์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ธ๊ฐ€์š”?
๋ณ€๊ฒฝํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ใ…Žใ…Ž

Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package com.aliens.backend.block.domain;

import com.aliens.backend.auth.domain.Member;
import jakarta.persistence.*;

@Entity
public class Block {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column
private Long id;

@ManyToOne
@JoinColumn(name = "blocking_member_id")
private Member blockingMember;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join ๋„ฃ์–ด์ฃผ์…จ๊ตฐ์š”!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ…‹ใ…‹ใ…  ํ”ผ๋“œ๋ฐฑ ๋“œ๋ฆฐ ๋‚ด์šฉ์„ ์ œ๊ฐ€ ์ˆ˜์ •ํ•ด์„œ ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค..
ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ•ด์„œ ๋Œ์•„๊ฐ€๋„๋ก ํ•ด๋„, ์—”ํ‹ฐํ‹ฐ๊ฐ€ ์ˆ˜์ •๋˜๋ฉด ๋‹ค์‹œ ํ…Œ์ŠคํŠธ์ฝ”๋“œ๋ฅผ ์™„์ „ ์ˆ˜์ •ํ•˜๊ฒŒ๋˜๋Š” ์ƒํ™ฉ์ด ๋ฒŒ์–ด์ ธ์„œ..
์ œ๊ฐ€ ์ผ๋‹จ ์—”ํ‹ฐํ‹ฐ์— join. ์ž‘์—…์„ ์ˆ˜ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค ๐Ÿฅฒ


@ManyToOne
@JoinColumn(name = "blocked_member_id")
private Member blockedMember;

protected Block() {
}

public static Block of(Member blockedMember, Member blockingMember) {
Block block = new Block();
block.blockingMember = blockingMember;
block.blockedMember = blockedMember;
return block;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.aliens.backend.block.domain.repository;

import com.aliens.backend.block.domain.Block;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.stereotype.Repository;

@Repository
public interface BlockRepository extends JpaRepository<Block, Long> {
}
63 changes: 63 additions & 0 deletions src/main/java/com/aliens/backend/block/service/BlockService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
package com.aliens.backend.block.service;

import com.aliens.backend.auth.controller.dto.LoginMember;
import com.aliens.backend.auth.domain.Member;
import com.aliens.backend.auth.domain.repository.MemberRepository;
import com.aliens.backend.block.domain.repository.BlockRepository;
import com.aliens.backend.block.controller.dto.BlockRequest;
import com.aliens.backend.block.domain.Block;
import com.aliens.backend.chat.domain.ChatRoom;
import com.aliens.backend.chat.domain.repository.ChatRoomRepository;
import com.aliens.backend.global.exception.RestApiException;
import com.aliens.backend.global.response.error.MemberError;
import com.aliens.backend.global.response.success.ChatSuccess;
import jakarta.transaction.Transactional;
import org.springframework.stereotype.Service;

import java.util.List;

@Service
public class BlockService {
private final BlockRepository blockRepository;
private final ChatRoomRepository chatRoomRepository;
private final MemberRepository memberRepository;

public BlockService(BlockRepository blockRepository, ChatRoomRepository chatRoomRepository, final MemberRepository memberRepository) {
this.blockRepository = blockRepository;
this.chatRoomRepository = chatRoomRepository;
this.memberRepository = memberRepository;
}

@Transactional
public String blockPartner(LoginMember loginMember, BlockRequest blockRequest) {
blockMember(loginMember, blockRequest);
blockChatRoom(blockRequest);
return ChatSuccess.BLOCK_SUCCESS.getMessage();
}

private void blockMember(final LoginMember loginMember, final BlockRequest blockRequest) {
Member blockingMember = getMember(loginMember);
Member blockedMember = findMemberById(blockRequest.partnerId());

Block block = Block.of(blockingMember, blockedMember);
blockRepository.save(block);
}

private void blockChatRoom(final BlockRequest blockRequest) {
List<ChatRoom> chatRooms = findChatRoomsById(blockRequest.chatRoomId());
chatRooms.forEach(ChatRoom::block);
chatRoomRepository.saveAll(chatRooms);
}

private List<ChatRoom> findChatRoomsById(final Long chatRoomId) {
return chatRoomRepository.findByRoomId(chatRoomId);
}

private Member findMemberById(final Long partnerId) {
return memberRepository.findById(partnerId).orElseThrow(() -> new RestApiException(MemberError.NULL_MEMBER));
}

private Member getMember(final LoginMember loginMember) {
return memberRepository.findById(loginMember.memberId()).orElseThrow(() -> new RestApiException(MemberError.NULL_MEMBER));
}
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@
import com.aliens.backend.chat.domain.Message;
import com.aliens.backend.chat.service.ChatService;
import com.aliens.backend.global.config.resolver.Login;
import org.springframework.http.ResponseEntity;
import com.aliens.backend.global.response.SuccessResponse;
import com.aliens.backend.global.response.success.ChatSuccess;
import org.springframework.messaging.handler.annotation.MessageMapping;
import org.springframework.messaging.handler.annotation.Payload;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;

import java.util.Collections;
import java.util.List;
import java.util.Map;


@RestController
Expand All @@ -39,17 +38,22 @@ public void readMessage(@Payload ReadRequest readRequest) {
}

@GetMapping("/chat/summaries")
public ResponseEntity<Map<String, ChatSummaryResponse>> getChatSummaries(@Login Long memberId) {
ChatSummaryResponse chatSummaryResponse = chatService.getChatSummaries(memberId);
Map<String, ChatSummaryResponse> response = Collections.singletonMap("response", chatSummaryResponse);
return ResponseEntity.ok(response);
public SuccessResponse<ChatSummaryResponse> getChatSummaries(@Login Long memberId) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(@Login Long memberId) ์ด ๋ถ€๋ถ„
@Login LoginMember loginMember ๋กœ ๋ณ€๊ฒฝ๋˜์–ด์•ผ ํ•˜์ง€ ์•Š๋‚˜์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๊ฐ€ ์„ฑ๊ณตํ•˜๋„๋ก๋งŒ ํ”ผ๋“œ๋ฐฑ ํ—€๋˜ ๋ถ€๋ถ„์„ ์ตœ๋Œ€ํ•œ ์ˆ˜์ •ํ•˜์ง€ ์•Š๊ณ ์ž ํ–ˆ์Šต๋‹ˆ๋‹ค. (์•Œ๊ณ  ์žˆ๋Š”๋ฐ ์ผ๋‹จ ๋’€์–ด์š” ๐Ÿฅฒ)
์ œ๊ฐ€ ์ˆ˜์ •ํ•œ ๋ถ€๋ถ„๋“ค์€ ์ •๋ง ํ…Œ์ŠคํŠธ ๋ณ€๊ฒฝ์— ํ•„์š”ํ•ด์„œ ์ˆ˜์ •ํ•œ ๋ถ€๋ถ„๋“ค์ž…๋‹ˆ๋‹ค๐Ÿ™‹โ€โ™‚๏ธ


return SuccessResponse.of(
ChatSuccess.GET_SUMMARIES_SUCCESS,
chatService.getChatSummaries(memberId)
);
}

@GetMapping("/chat/room/{roomId}/messages")
public ResponseEntity<Map<String, List>> getMessages(@PathVariable("roomId") Long chatRoomId,
@RequestParam(value = "lastMessageId", required = false) String lastMessageId) {
List<Message> messages = chatService.getMessages(chatRoomId,lastMessageId);
Map<String, List> response = Collections.singletonMap("response", messages);
return ResponseEntity.ok(response);
public SuccessResponse<List<Message>> getMessages(@PathVariable("roomId") Long chatRoomId,
@RequestParam(value = "lastMessageId", required = false) String messageId) {

return SuccessResponse.of(
ChatSuccess.GET_MESSAGES_SUCCESS,
chatService.getMessages(chatRoomId,messageId)
);

}
}
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
package com.aliens.backend.chat.controller;

import com.aliens.backend.auth.controller.dto.LoginMember;
import com.aliens.backend.chat.controller.dto.request.ChatReportRequest;
import com.aliens.backend.chat.service.ChatReportService;
import com.aliens.backend.global.config.resolver.Login;
import org.springframework.http.ResponseEntity;
import org.springframework.stereotype.Controller;
import com.aliens.backend.global.response.SuccessResponse;
import com.aliens.backend.global.response.success.ChatSuccess;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;

import java.util.Collections;
import java.util.Map;


@RestController
public class ChatReportController {
Expand All @@ -23,9 +21,12 @@ public ChatReportController(ChatReportService chatReportService) {
}

@PostMapping("/chat/report")
public ResponseEntity<Map<String, String>> reportPartner(@Login Long memberId, @RequestBody ChatReportRequest chatReportRequest) {
String result = chatReportService.reportPartner(memberId, chatReportRequest);
Map<String, String> response = Collections.singletonMap("response", result);
return ResponseEntity.ok(response);
public SuccessResponse<String> reportPartner(@Login LoginMember loginMember,
@RequestBody ChatReportRequest chatReportRequest) {

return SuccessResponse.of(
ChatSuccess.REPORT_SUCCESS,
chatReportService.reportPartner(loginMember, chatReportRequest)
);
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package com.aliens.backend.chat.controller.dto.request;

public record ChatReportRequest(Long partnerId, Long chatRoomId, String category, String content) {
import com.aliens.backend.chat.domain.ChatReportCategory;

public record ChatReportRequest(Long partnerId, Long chatRoomId, ChatReportCategory category, String content) {
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package com.aliens.backend.chat.controller.dto.request;

public record MessageSendRequest(String type, String content, Long roomId, Long senderId, Long receiverId) {
import com.aliens.backend.chat.domain.MessageType;

public record MessageSendRequest(MessageType type, String content, Long roomId, Long senderId, Long receiverId) {
}
Loading
Loading