Feat/#136 채팅 만료 이벤트 핸들러 추가 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhyun0918
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
@coke98
제가 이벤트 발행 코드를 만들어 놓고는 깜빡하고 이벤트 수신 코드를 작성해달라고 말씀을 못드렸네요 !
:(
뒤늦게 업무 부담을 드리게되어 죄송합니다! ㅠㅠ
+++
알맞게 수정해주셔서 감사합니다!
고생 많으셨습니다!
Comment on lines
+30
to
+31
| public void expireChatRoom() { | ||
| eventPublisher.publishEvent(new ChatRoomExpireEvent()); |
There was a problem hiding this comment.
List matchingResults를 이벤트로 전송하지 않으니,
매칭 로직중 메모리 절약도 생각할 수 있겠네요! 👍
| import java.util.Set; | ||
|
|
||
| public record ChatRoomExpireEvent(Set<MemberPair> matchedPairs) { | ||
| public record ChatRoomExpireEvent() { |
There was a problem hiding this comment.
레코드가 비어있어도 정상적으로 이벤트가 발송되는 사실을 처음 알았습니다!
고생하셨습니다!
mjj111
approved these changes
Jul 28, 2024
| import java.util.Set; | ||
|
|
||
| public record ChatRoomExpireEvent(Set<MemberPair> matchedPairs) { | ||
| public record ChatRoomExpireEvent() { |
Comment on lines
+30
to
+31
| public void expireChatRoom() { | ||
| eventPublisher.publishEvent(new ChatRoomExpireEvent()); |
There was a problem hiding this comment.
List matchingResults를 이벤트로 전송하지 않으니,
매칭 로직중 메모리 절약도 생각할 수 있겠네요! 👍
50000ms->20000ms 재수정 ref: #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤨 Motivation
🔑 Key Changes
🙏 To Reviewers